From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Matthias Reichl <hias@horus.com>
Cc: Anthony Mallet <anthony.mallet@laas.fr>,
Oliver Neukum <oneukum@suse.com>,
linux-usb@vger.kernel.org
Subject: Re: [PATCH] USB: cdc-acm: restore capability check order
Date: Fri, 27 Mar 2020 16:33:28 +0100 [thread overview]
Message-ID: <20200327153328.GA3167199@kroah.com> (raw)
In-Reply-To: <20200327150350.3657-1-hias@horus.com>
On Fri, Mar 27, 2020 at 04:03:50PM +0100, Matthias Reichl wrote:
> commit b401f8c4f492c ("USB: cdc-acm: fix rounding error in TIOCSSERIAL")
> introduced a regression by changing the order of capability and close
> settings change checks. When running with CAP_SYS_ADMIN setting the
> close settings to the values already set resulted in -EOPNOTSUPP.
>
> Fix this by changing the check order back to how it was before.
>
> Fixes: b401f8c4f492c ("USB: cdc-acm: fix rounding error in TIOCSSERIAL")
> Cc: Anthony Mallet <anthony.mallet@laas.fr>
> Cc: stable <stable@vger.kernel.org>
> Cc: Oliver Neukum <oneukum@suse.com>
> Signed-off-by: Matthias Reichl <hias@horus.com>
> ---
> drivers/usb/class/cdc-acm.c | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
Thanks for this, now queued up.
greg k-h
prev parent reply other threads:[~2020-03-27 15:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-27 15:03 [PATCH] USB: cdc-acm: restore capability check order Matthias Reichl
2020-03-27 15:33 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200327153328.GA3167199@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=anthony.mallet@laas.fr \
--cc=hias@horus.com \
--cc=linux-usb@vger.kernel.org \
--cc=oneukum@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.