All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Subject: [Intel-gfx] [PATCH 08/10] drm/i915/gem: Teach execbuf how to wait on future syncobj
Date: Fri,  3 Apr 2020 10:12:58 +0100	[thread overview]
Message-ID: <20200403091300.14734-8-chris@chris-wilson.co.uk> (raw)
In-Reply-To: <20200403091300.14734-1-chris@chris-wilson.co.uk>

If a syncobj has not yet been assigned, treat it as a future fence and
install and wait upon a dma-fence-proxy. The proxy will be replace by
the real fence later, and that fence will be responsible for signaling
our waiter.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 .../gpu/drm/i915/gem/i915_gem_execbuffer.c    | 21 +++++++++++++++++--
 1 file changed, 19 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
index 9d11bad74e9a..bf1b5399ffa3 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
@@ -5,6 +5,7 @@
  */
 
 #include <linux/intel-iommu.h>
+#include <linux/dma-fence-proxy.h>
 #include <linux/dma-resv.h>
 #include <linux/sync_file.h>
 #include <linux/uaccess.h>
@@ -2334,8 +2335,24 @@ await_fence_array(struct i915_execbuffer *eb,
 			continue;
 
 		fence = drm_syncobj_fence_get(syncobj);
-		if (!fence)
-			return -EINVAL;
+		if (!fence) {
+			struct dma_fence *old;
+
+			fence = dma_fence_create_proxy();
+			if (!fence)
+				return -ENOMEM;
+
+			spin_lock(&syncobj->lock);
+			old = rcu_dereference_protected(syncobj->fence, true);
+			if (unlikely(old)) {
+				dma_fence_put(fence);
+				fence = dma_fence_get(old);
+			} else {
+				rcu_assign_pointer(syncobj->fence,
+						   dma_fence_get(fence));
+			}
+			spin_unlock(&syncobj->lock);
+		}
 
 		err = i915_request_await_dma_fence(eb->request, fence);
 		dma_fence_put(fence);
-- 
2.20.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2020-04-03  9:13 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-03  9:12 [Intel-gfx] [PATCH 01/10] drm/i915/selftests: Add request throughput measurement to perf Chris Wilson
2020-04-03  9:12 ` [Intel-gfx] [PATCH 02/10] drm/i915/gt: Yield the timeslice if caught waiting on a user semaphore Chris Wilson
2020-04-07  9:07   ` Tvrtko Ursulin
2020-04-03  9:12 ` [Intel-gfx] [PATCH 03/10] dma-buf: Prettify typecasts for dma-fence-chain Chris Wilson
2020-04-03  9:12 ` [Intel-gfx] [PATCH 04/10] dma-buf: Report signaled links inside dma-fence-chain Chris Wilson
2020-04-08 19:46   ` Venkata Sandeep Dhanalakota
2020-04-08 20:00   ` Lionel Landwerlin
2020-04-09 10:52     ` Chris Wilson
2020-04-09 11:16       ` Lionel Landwerlin
2020-04-09 13:46         ` Chris Wilson
2020-04-03  9:12 ` [Intel-gfx] [PATCH 05/10] dma-buf: Exercise dma-fence-chain under selftests Chris Wilson
2020-04-08 19:49   ` Venkata Sandeep Dhanalakota
2020-04-10 16:11   ` Lionel Landwerlin
2020-04-03  9:12 ` [Intel-gfx] [PATCH 06/10] dma-buf: Proxy fence, an unsignaled fence placeholder Chris Wilson
2020-04-05 22:14   ` kbuild test robot
2020-04-05 22:14     ` kbuild test robot
2020-04-06 18:32     ` Nick Desaulniers
2020-04-06 18:32       ` Nick Desaulniers
2020-04-03  9:12 ` [Intel-gfx] [PATCH 07/10] drm/syncobj: Allow use of dma-fence-proxy Chris Wilson
2020-04-03  9:12 ` Chris Wilson [this message]
2020-04-03  9:12 ` [Intel-gfx] [PATCH 09/10] drm/i915/gem: Allow combining submit-fences with syncobj Chris Wilson
2020-04-07 10:44   ` Tvrtko Ursulin
2020-04-07 10:51     ` Chris Wilson
2020-04-08  9:28       ` Tvrtko Ursulin
2020-04-03  9:13 ` [Intel-gfx] [PATCH 10/10] drm/i915/gt: Declare when we enabled timeslicing Chris Wilson
2020-04-07 10:50   ` Tvrtko Ursulin
2020-04-07 10:55     ` Chris Wilson
2020-04-03  9:32 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/10] drm/i915/selftests: Add request throughput measurement to perf Patchwork
2020-04-03  9:58 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-04-03 17:23 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2020-03-31 21:25 [Intel-gfx] [PATCH 01/10] " Chris Wilson
2020-03-31 21:25 ` [Intel-gfx] [PATCH 08/10] drm/i915/gem: Teach execbuf how to wait on future syncobj Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200403091300.14734-8-chris@chris-wilson.co.uk \
    --to=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.