From: Christoph Hellwig <hch@infradead.org>
To: Andrzej Pietrasiewicz <andrzej.p@collabora.com>
Cc: Christoph Hellwig <hch@infradead.org>,
evgreen@chromium.org, asavery@chromium.org, axboe@kernel.dk,
bvanassche@acm.org, darrick.wong@oracle.com,
dianders@chromium.org, gwendal@chromium.org,
linux-block@vger.kernel.org, martin.petersen@oracle.com,
ming.lei@redhat.com, kernel@collabora.com
Subject: Re: [PATCH v8 2/2] loop: Better discard support for block devices
Date: Fri, 3 Apr 2020 04:15:44 -0700 [thread overview]
Message-ID: <20200403111544.GA27769@infradead.org> (raw)
In-Reply-To: <49a20f42-f082-be3a-52f8-a4179ab886c0@collabora.com>
On Fri, Apr 03, 2020 at 12:27:26PM +0200, Andrzej Pietrasiewicz wrote:
> > The backingq could move into this local scope.
> >
> > > + } else if ((!file->f_op->fallocate) || lo->lo_encrypt_key_size) {
> >
> > No need for the inner braces.
> >
> > But the actual functionality looks good to me.
> >
>
> Would you A-b or R-b if I corrected the two small issues which you found?
Sure:
Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2020-04-03 11:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-02 17:06 [PATCH v8 0/2] Better discard support for block devices Andrzej Pietrasiewicz
2020-04-02 17:06 ` [PATCH v8 1/2] loop: Report EOPNOTSUPP properly Andrzej Pietrasiewicz
2020-04-03 6:38 ` Christoph Hellwig
2020-04-02 17:06 ` [PATCH v8 2/2] loop: Better discard support for block devices Andrzej Pietrasiewicz
2020-04-03 6:39 ` Christoph Hellwig
2020-04-03 10:27 ` Andrzej Pietrasiewicz
2020-04-03 11:15 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200403111544.GA27769@infradead.org \
--to=hch@infradead.org \
--cc=andrzej.p@collabora.com \
--cc=asavery@chromium.org \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=darrick.wong@oracle.com \
--cc=dianders@chromium.org \
--cc=evgreen@chromium.org \
--cc=gwendal@chromium.org \
--cc=kernel@collabora.com \
--cc=linux-block@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.