From: Joel Fernandes <joel@joelfernandes.org>
To: David Rientjes <rientjes@google.com>
Cc: Michal Hocko <mhocko@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Neil Brown <neilb@suse.de>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>,
Michal Hocko <mhocko@suse.com>,
"Paul E . McKenney" <paulmck@kernel.org>
Subject: Re: [PATCH 2/2] mm: make it clear that gfp reclaim modifiers are valid only for sleepable allocations
Date: Mon, 6 Apr 2020 21:38:55 -0400 [thread overview]
Message-ID: <20200407013855.GA11326@google.com> (raw)
In-Reply-To: <alpine.DEB.2.21.2004031241380.230548@chino.kir.corp.google.com>
On Fri, Apr 03, 2020 at 12:41:51PM -0700, David Rientjes wrote:
> On Fri, 3 Apr 2020, Michal Hocko wrote:
>
> > From: Michal Hocko <mhocko@suse.com>
> >
> > While it might be really clear to MM developers that gfp reclaim
> > modifiers are applicable only to sleepable allocations (those with
> > __GFP_DIRECT_RECLAIM) it seems that actual users of the API are not
> > always sure. Make it explicit that they are not applicable for
> > GFP_NOWAIT or GFP_ATOMIC allocations which are the most commonly used
> > non-sleepable allocation masks.
> >
> > Acked-by: Paul E. McKenney <paulmck@kernel.org>
> > Signed-off-by: Michal Hocko <mhocko@suse.com>
>
> Acked-by: David Rientjes <rientjes@google.com>
Reviewed-by: Joel Fernandes (Google) <joel@joelfernandes.org>
thanks,
- Joel
prev parent reply other threads:[~2020-04-07 1:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 8:35 [PATCH 0/2] mm: few refinements to gfp flags documentation Michal Hocko
2020-04-03 8:35 ` [PATCH 1/2] mm: clarify __GFP_MEMALLOC usage Michal Hocko
2020-04-03 19:41 ` David Rientjes
2020-04-03 19:41 ` David Rientjes
2020-04-03 21:23 ` NeilBrown
2020-04-06 7:01 ` Michal Hocko
2020-04-06 19:02 ` John Hubbard
2020-04-06 23:32 ` David Rientjes
2020-04-06 23:32 ` David Rientjes
2020-04-06 23:40 ` John Hubbard
2020-04-14 2:15 ` Andrew Morton
2020-04-14 3:56 ` NeilBrown
2020-04-14 19:05 ` John Hubbard
2020-04-07 1:00 ` NeilBrown
2020-04-07 1:21 ` John Hubbard
2020-04-07 7:24 ` Michal Hocko
2020-04-03 8:35 ` [PATCH 2/2] mm: make it clear that gfp reclaim modifiers are valid only for sleepable allocations Michal Hocko
2020-04-03 19:41 ` David Rientjes
2020-04-03 19:41 ` David Rientjes
2020-04-07 1:38 ` Joel Fernandes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200407013855.GA11326@google.com \
--to=joel@joelfernandes.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mhocko@suse.com \
--cc=neilb@suse.de \
--cc=paulmck@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.