From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
To: linux-renesas-soc@vger.kernel.org,
"Jacopo Mondi" <jacopo@jmondi.org>,
"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
"Niklas Söderlund" <niklas.soderlund@ragnatech.se>,
"Hyun Kwon" <hyunk@xilinx.com>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>
Cc: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Subject: [PATCH v8 09/13] sqaush! max9286: Lock format changes
Date: Thu, 9 Apr 2020 13:11:58 +0100 [thread overview]
Message-ID: <20200409121202.11130-10-kieran.bingham+renesas@ideasonboard.com> (raw)
In-Reply-To: <20200409121202.11130-1-kieran.bingham+renesas@ideasonboard.com>
Provide a mutex to protect against format changes on the pads. The
mutex can also be used to protect against control changes, or other
userspace facing interactions as necessary
Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
---
drivers/media/i2c/max9286.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c
index 911323d6d3c4..17830c362a50 100644
--- a/drivers/media/i2c/max9286.c
+++ b/drivers/media/i2c/max9286.c
@@ -18,6 +18,7 @@
#include <linux/i2c.h>
#include <linux/i2c-mux.h>
#include <linux/module.h>
+#include <linux/mutex.h>
#include <linux/of_graph.h>
#include <linux/regulator/consumer.h>
#include <linux/slab.h>
@@ -157,6 +158,9 @@ struct max9286_priv {
struct v4l2_mbus_framefmt fmt[MAX9286_N_SINKS];
+ /* Protects controls and fmt structures */
+ struct mutex mutex;
+
unsigned int nsources;
unsigned int source_mask;
unsigned int route_mask;
@@ -680,7 +684,9 @@ static int max9286_set_fmt(struct v4l2_subdev *sd,
if (!cfg_fmt)
return -EINVAL;
+ mutex_lock(&priv->mutex);
*cfg_fmt = format->format;
+ mutex_unlock(&priv->mutex);
return 0;
}
@@ -699,7 +705,9 @@ static int max9286_get_fmt(struct v4l2_subdev *sd,
if (!cfg_fmt)
return -EINVAL;
+ mutex_lock(&priv->mutex);
format->format = *cfg_fmt;
+ mutex_unlock(&priv->mutex);
return 0;
}
@@ -1148,6 +1156,8 @@ static int max9286_probe(struct i2c_client *client)
if (!priv)
return -ENOMEM;
+ mutex_init(&priv->mutex);
+
priv->client = client;
i2c_set_clientdata(client, priv);
--
2.20.1
next prev parent reply other threads:[~2020-04-09 12:12 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-09 12:11 [PATCH v8 00/13] max9286 v8 - modifications Kieran Bingham
2020-04-09 12:11 ` [PATCH v8 01/13] squash! max9286: Update the bound_sources mask on unbind Kieran Bingham
2020-04-09 15:20 ` Jacopo Mondi
2020-04-09 12:11 ` [PATCH v8 02/13] squash! max9286: convert probe kzalloc Kieran Bingham
2020-04-09 16:33 ` Laurent Pinchart
2020-04-10 8:20 ` Kieran Bingham
2020-04-10 11:15 ` Laurent Pinchart
2020-04-23 7:38 ` Sakari Ailus
2020-04-23 9:32 ` Laurent Pinchart
2020-04-23 10:55 ` Kieran Bingham
2020-04-23 23:25 ` Sakari Ailus
2020-04-09 17:08 ` [PATCH] squash! i2c: max9286: Put of node on error Jacopo Mondi
2020-04-09 20:20 ` Jacopo Mondi
2020-04-10 7:20 ` Kieran Bingham
2020-04-09 12:11 ` [PATCH v8 03/13] squash! max9286: Fix cleanup path from GPIO powerdown Kieran Bingham
2020-04-09 16:22 ` Jacopo Mondi
2020-04-10 7:34 ` Geert Uytterhoeven
2020-04-10 7:41 ` Kieran Bingham
2020-04-10 7:52 ` Jacopo Mondi
2020-04-10 7:38 ` Kieran Bingham
2020-04-10 7:42 ` Kieran Bingham
2020-04-11 12:33 ` Jacopo Mondi
2020-04-09 12:11 ` [PATCH v8 04/13] squash! max9286: cleanup GPIO device registration fail path Kieran Bingham
2020-04-09 12:11 ` [PATCH v8 05/13] squash! max9286: Convert to use devm_regulator_get() Kieran Bingham
2020-04-09 12:15 ` Kieran Bingham
2020-04-09 12:11 ` [PATCH v8 06/13] squash! max9286: Fit max9286_parse_dt print on one line Kieran Bingham
2020-04-09 12:11 ` [PATCH v8 07/13] squash! max9286: Move multi-device workarounds out of upstream Kieran Bingham
2020-04-09 12:11 ` [PATCH v8 08/13] squash! max9286: Remove I2C mod-table Kieran Bingham
2020-04-09 12:11 ` Kieran Bingham [this message]
2020-04-09 12:11 ` [PATCH v8 10/13] squash! max9286: Implement Pixelrate control Kieran Bingham
2020-04-09 16:29 ` Jacopo Mondi
2020-04-10 7:51 ` Kieran Bingham
2020-04-10 12:35 ` Jacopo Mondi
2020-04-14 10:50 ` Jacopo Mondi
2020-04-14 21:10 ` Laurent Pinchart
2020-04-15 9:13 ` Jacopo Mondi
2020-04-15 15:28 ` Laurent Pinchart
2020-04-09 12:12 ` [PATCH v8 11/13] squash! max9286: Disable overlap window Kieran Bingham
2020-04-09 16:32 ` Jacopo Mondi
2020-04-10 7:14 ` Kieran Bingham
2020-04-10 7:48 ` Jacopo Mondi
2020-04-09 12:12 ` [PATCH v8 12/13] sqaush! max9286: Describe pad index usage Kieran Bingham
2020-04-09 12:12 ` [PATCH v8 13/13] sqaush! max9286: Remove poc_enabled workaround Kieran Bingham
2020-04-09 16:33 ` Jacopo Mondi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200409121202.11130-10-kieran.bingham+renesas@ideasonboard.com \
--to=kieran.bingham+renesas@ideasonboard.com \
--cc=hyunk@xilinx.com \
--cc=jacopo@jmondi.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=niklas.soderlund@ragnatech.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.