Re: [RFC PATCH 5/5] ACPI: processor: do update when maximum cooling state changed

From: kbuild test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [RFC PATCH 5/5] ACPI: processor: do update when maximum cooling state changed
Date: Tue, 14 Apr 2020 00:16:18 +0800	[thread overview]
Message-ID: <202004140050.cJx3jQj5%lkp@intel.com> (raw)
In-Reply-To: <20200408041917.2329-5-rui.zhang@intel.com>

[-- Attachment #1: Type: text/plain, Size: 2329 bytes --]

Hi Zhang,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on pm/linux-next]
[also build test WARNING on linus/master v5.7-rc1 next-20200413]
[cannot apply to soc-thermal/next]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Zhang-Rui/thermal-rename-thermal_cooling_device_stats_update/20200408-122131
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

cppcheck warnings: (new ones prefixed by >>)

>> drivers/acpi/processor_thermal.c:158:33: warning: Either the condition 'if(pr)' is redundant or there is possible null pointer dereference: pr. [nullPointerRedundantCheck]
     thermal_cdev_stats_update_max(pr->cdev);
                                   ^
   drivers/acpi/processor_thermal.c:156:6: note: Assuming that condition 'if(pr)' is not redundant
     if (pr)
        ^
   drivers/acpi/processor_thermal.c:154:38: note: Assignment 'pr=per_cpu(processors,policy->cpu)', assigned value is 0
     struct acpi_processor *pr = per_cpu(processors, policy->cpu);
                                        ^
   drivers/acpi/processor_thermal.c:158:33: note: Null pointer dereference
     thermal_cdev_stats_update_max(pr->cdev);
                                   ^

vim +158 drivers/acpi/processor_thermal.c

   148	
   149	void acpi_thermal_cpufreq_exit(struct cpufreq_policy *policy)
   150	{
   151		unsigned int cpu;
   152	
   153		for_each_cpu(cpu, policy->related_cpus) {
   154			struct acpi_processor *pr = per_cpu(processors, policy->cpu);
   155	
   156			if (pr)
   157				freq_qos_remove_request(&pr->thermal_req);
 > 158			thermal_cdev_stats_update_max(pr->cdev);
   159		}
   160	}
   161	#else				/* ! CONFIG_CPU_FREQ */
   162	static int cpufreq_get_max_state(unsigned int cpu)
   163	{
   164		return 0;
   165	}
   166	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org