Re: [PATCH v1 2/4] drm/bridge: tc358764: drop drm_connector_(un)register

From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Jernej Skrabec <jernej.skrabec@siol.net>,
	Neil Armstrong <narmstrong@baylibre.com>,
	Jonas Karlman <jonas@kwiboo.se>,
	dri-devel@lists.freedesktop.org,
	Andrzej Hajda <a.hajda@samsung.com>,
	Thierry Reding <thierry.reding@gmail.com>
Subject: Re: [PATCH v1 2/4] drm/bridge: tc358764: drop drm_connector_(un)register
Date: Tue, 14 Apr 2020 12:33:56 +0300	[thread overview]
Message-ID: <20200414093356.GB19819@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20200414084727.8326-3-sam@ravnborg.org>

Hi Sam,

Thank you for the patch.

On Tue, Apr 14, 2020 at 10:47:25AM +0200, Sam Ravnborg wrote:
> Drop drm_connector handling that is not needed:
> 
> - drm_dev_register() in the display controlelr driver takes

s/controlelr/controller/

>   care of registering connectors.
>   So the call to drm_connector_register() call is not needed in the bridge
>   driver.
> 
> - Use of drm_connector_unregister() is only required for drivers that
>   explicit have called drm_dev_register.
> 
> - The reference counting using drm_connector_put() is likewise not needed.
> 
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Cc: Andrzej Hajda <a.hajda@samsung.com>
> Cc: Neil Armstrong <narmstrong@baylibre.com>
> Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
> Cc: Jonas Karlman <jonas@kwiboo.se>
> Cc: Jernej Skrabec <jernej.skrabec@siol.net>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  drivers/gpu/drm/bridge/tc358764.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/tc358764.c b/drivers/gpu/drm/bridge/tc358764.c
> index 5ac1430fab04..a277739fab58 100644
> --- a/drivers/gpu/drm/bridge/tc358764.c
> +++ b/drivers/gpu/drm/bridge/tc358764.c
> @@ -375,7 +375,6 @@ static int tc358764_attach(struct drm_bridge *bridge,
>  	drm_connector_attach_encoder(&ctx->connector, bridge->encoder);
>  	drm_panel_attach(ctx->panel, &ctx->connector);
>  	ctx->connector.funcs->reset(&ctx->connector);
> -	drm_connector_register(&ctx->connector);
>  
>  	return 0;
>  }
> @@ -384,10 +383,8 @@ static void tc358764_detach(struct drm_bridge *bridge)
>  {
>  	struct tc358764 *ctx = bridge_to_tc358764(bridge);
>  
> -	drm_connector_unregister(&ctx->connector);
>  	drm_panel_detach(ctx->panel);
>  	ctx->panel = NULL;
> -	drm_connector_put(&ctx->connector);
>  }
>  
>  static const struct drm_bridge_funcs tc358764_bridge_funcs = {

-- 
Regards,

Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel