From: Jessica Yu <jeyu@kernel.org>
To: Leon Romanovsky <leon@kernel.org>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Leon Romanovsky <leonro@mellanox.com>,
Borislav Petkov <bp@suse.de>,
linux-kbuild@vger.kernel.org,
Masahiro Yamada <masahiroy@kernel.org>,
Michal Marek <michal.lkml@markovi.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next v1 4/4] kernel/module: Hide vermagic header file from general use
Date: Fri, 17 Apr 2020 13:12:05 +0200 [thread overview]
Message-ID: <20200417111205.GB2582@linux-8ccs> (raw)
In-Reply-To: <20200415133648.1306956-5-leon@kernel.org>
+++ Leon Romanovsky [15/04/20 16:36 +0300]:
>From: Leon Romanovsky <leonro@mellanox.com>
>
>VERMAGIC* definitions are not supposed to be used by the drivers,
>see this [1] bug report, so simply move this header file to be visible
>to kernel/* and scripts files only.
>
>In-tree module build:
>➜ kernel git:(vermagic) ✗ make clean
>➜ kernel git:(vermagic) ✗ make M=drivers/infiniband/hw/mlx5
>➜ kernel git:(vermagic) ✗ modinfo drivers/infiniband/hw/mlx5/mlx5_ib.ko
>filename: /images/leonro/src/kernel/drivers/infiniband/hw/mlx5/mlx5_ib.ko
><...>
>vermagic: 5.6.0+ SMP mod_unload modversions
>
>Out-of-tree module build:
>➜ mlx5 make -C /images/leonro/src/kernel clean M=/tmp/mlx5
>➜ mlx5 make -C /images/leonro/src/kernel M=/tmp/mlx5
>➜ mlx5 modinfo /tmp/mlx5/mlx5_ib.ko
>filename: /tmp/mlx5/mlx5_ib.ko
><...>
>vermagic: 5.6.0+ SMP mod_unload modversions
>
>[1] https://lore.kernel.org/lkml/20200411155623.GA22175@zn.tnic
>Reported-by: Borislav Petkov <bp@suse.de>
>Acked-by: Borislav Petkov <bp@suse.de>
>Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
Acked-by: Jessica Yu <jeyu@kernel.org>
next prev parent reply other threads:[~2020-04-17 11:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 13:36 [PATCH net-next v1 0/4] Remove vermagic header from global include folder Leon Romanovsky
2020-04-15 13:36 ` [PATCH net-next v1 1/4] drivers: Remove inclusion of vermagic header Leon Romanovsky
2020-04-15 13:36 ` [PATCH net-next v1 2/4] net/hns: Remove custom driver version in favour of global one Leon Romanovsky
2020-04-15 13:36 ` [PATCH net-next v1 3/4] net/nfp: Update driver to use global kernel version Leon Romanovsky
2020-04-15 13:36 ` [PATCH net-next v1 4/4] kernel/module: Hide vermagic header file from general use Leon Romanovsky
2020-04-17 11:12 ` Jessica Yu [this message]
2020-04-17 12:07 ` Masahiro Yamada
2020-04-17 14:37 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200417111205.GB2582@linux-8ccs \
--to=jeyu@kernel.org \
--cc=bp@suse.de \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=leonro@mellanox.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.