From: Tim Deegan <tim@xen.org>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
"Roger Pau Monné" <roger.pau@citrix.com>,
"George Dunlap" <george.dunlap@citrix.com>,
"Wei Liu" <wl@xen.org>,
"Andrew Cooper" <andrew.cooper3@citrix.com>
Subject: Re: [PATCH 07/10] x86/shadow: the guess_wrmap() hook is needed for HVM only
Date: Sat, 18 Apr 2020 10:03:17 +0100 [thread overview]
Message-ID: <20200418090317.GD92478@deinos.phlegethon.org> (raw)
In-Reply-To: <1e221192-7899-b60d-0280-b77ab5877772@suse.com>
At 16:28 +0200 on 17 Apr (1587140897), Jan Beulich wrote:
> sh_remove_write_access() bails early for !external guests, and hence its
> building and thus the need for the hook can be suppressed altogether in
> !HVM configs.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> @@ -366,6 +367,14 @@ int sh_validate_guest_entry(struct vcpu
> extern int sh_remove_write_access(struct domain *d, mfn_t readonly_mfn,
> unsigned int level,
> unsigned long fault_addr);
> +#else
> +static inline int sh_remove_write_access(struct domain *d, mfn_t readonly_mfn,
> + unsigned int level,
> + unsigned long fault_addr)
> +{
Can we have an ASSERT(!shadow_mode_refcounts(d)) here, please,
matching the check that would have made it a noop before?
Cheers,
Tim.
next prev parent reply other threads:[~2020-04-18 9:03 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 14:23 [PATCH 00/10] x86: mm (mainly shadow) adjustments Jan Beulich
2020-04-17 14:25 ` [PATCH 01/10] x86/mm: no-one passes a NULL domain to init_xen_l4_slots() Jan Beulich
2020-04-17 19:46 ` Andrew Cooper
2020-04-20 5:48 ` Jan Beulich
2020-04-22 12:20 ` Andrew Cooper
2020-04-17 14:25 ` [PATCH 02/10] x86/shadow: drop a stray forward structure declaration Jan Beulich
2020-04-17 14:26 ` [PATCH 03/10] x86/shadow: monitor table is HVM-only Jan Beulich
2020-04-17 19:51 ` Andrew Cooper
2020-04-17 14:26 ` [PATCH 04/10] x86/shadow: sh_update_linear_entries() is a no-op for PV Jan Beulich
2020-04-18 8:56 ` Tim Deegan
2020-04-17 14:27 ` [PATCH 05/10] x86/mm: monitor table is HVM-only Jan Beulich
2020-04-17 14:27 ` [PATCH 06/10] x86/shadow: sh_remove_write_access_from_sl1p() can be static Jan Beulich
2020-04-17 14:28 ` [PATCH 07/10] x86/shadow: the guess_wrmap() hook is needed for HVM only Jan Beulich
2020-04-18 9:03 ` Tim Deegan [this message]
2020-04-20 13:06 ` Jan Beulich
2020-04-21 5:31 ` Tim Deegan
2020-04-17 14:28 ` [PATCH 08/10] x86/mm: pagetable_dying() is HVM-only Jan Beulich
2020-04-17 14:29 ` [PATCH 09/10] x86/shadow: the trace_emul_write_val() hook " Jan Beulich
2020-04-17 14:29 ` [PATCH 10/10] x86/shadow: don't open-code shadow_blow_tables_per_domain() Jan Beulich
2020-04-17 20:12 ` [PATCH 00/10] x86: mm (mainly shadow) adjustments Andrew Cooper
2020-04-18 9:04 ` Tim Deegan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200418090317.GD92478@deinos.phlegethon.org \
--to=tim@xen.org \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=jbeulich@suse.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.