Re: [PATCH] Input: xpad - Update xboxone fw2015 init packet

From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: LuK1337 <priv.luk@gmail.com>,
	Cameron Gutman <aicommander@gmail.com>,
	Mark Furneaux <mark@furneaux.ca>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Richard Fontana <rfontana@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Allison Randal <allison@lohutok.net>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: xpad - Update xboxone fw2015 init packet
Date: Sun, 19 Apr 2020 11:01:36 -0700	[thread overview]
Message-ID: <20200419180136.GK166864@dtor-ws> (raw)
In-Reply-To: <20200419074624.9955-1-priv.luk@gmail.com>

On Sun, Apr 19, 2020 at 09:46:23AM +0200, LuK1337 wrote:
> From: Łukasz Patron <priv.luk@gmail.com>
> 
> Appending { 0x05, 0x20, 0x02, 0x0f, 0x06 } to
> xboxone_fw2015_init fixes an issue where the
> controller is somewhat stuck in bluetooth
> mode until you plug it into Windows PC.
> 
> Signed-off-by: Łukasz Patron <priv.luk@gmail.com>

Thank you Łukasz. Could you please tell me what device(s) have you
observed the issue with? I am a bit worried if this may interfere with
other devices that currently work fine with the driver. Cameron, Mark,
do you have any concerns here?

> ---
>  drivers/input/joystick/xpad.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
> index 6b40a1c68f9f..894fa81f717a 100644
> --- a/drivers/input/joystick/xpad.c
> +++ b/drivers/input/joystick/xpad.c
> @@ -455,7 +455,8 @@ struct xboxone_init_packet {
>   * or later firmware installed (or present from the factory).
>   */
>  static const u8 xboxone_fw2015_init[] = {
> -	0x05, 0x20, 0x00, 0x01, 0x00
> +	0x05, 0x20, 0x00, 0x01, 0x00,
> +	0x05, 0x20, 0x02, 0x0f, 0x06
>  };
>  
>  /*
> -- 
> 2.26.0
> 

Thanks.

-- 
Dmitry