From: Matthew Wilcox <willy@infradead.org>
To: Ritesh Harjani <riteshh@linux.ibm.com>
Cc: Eric Biggers <ebiggers@kernel.org>,
linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
"Darrick J . Wong" <darrick.wong@oracle.com>,
Christoph Hellwig <hch@infradead.org>, Jan Kara <jack@suse.com>,
tytso@mit.edu, "Aneesh Kumar K . V" <aneesh.kumar@linux.ibm.com>,
linux-ext4@vger.kernel.org
Subject: Re: [PATCH 1/2] fibmap: Warn and return an error in case of block > INT_MAX
Date: Fri, 24 Apr 2020 16:40:58 -0700 [thread overview]
Message-ID: <20200424234058.GA29705@bombadil.infradead.org> (raw)
In-Reply-To: <20200424225425.6521D4C040@d06av22.portsmouth.uk.ibm.com>
On Sat, Apr 25, 2020 at 04:24:24AM +0530, Ritesh Harjani wrote:
> Ok, I see.
> Let me replace WARN() with below pr_warn() line then. If no objections,
> then will send this in a v2 with both patches combined as Darrick
> suggested. - (with Reviewed-by tags of Jan & Christoph).
>
> pr_warn("fibmap: this would truncate fibmap result\n");
We generally don't like userspace to be able to trigger kernel messages
on demand, so they can't swamp the logfiles. printk_ratelimited()?
next prev parent reply other threads:[~2020-04-24 23:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 7:22 [PATCH 0/2] WARN fibmap user in case of possible addr truncation Ritesh Harjani
2020-04-24 7:22 ` [PATCH 1/2] fibmap: Warn and return an error in case of block > INT_MAX Ritesh Harjani
2020-04-24 9:57 ` Jan Kara
2020-04-24 10:07 ` Christoph Hellwig
2020-04-24 19:17 ` Eric Biggers
2020-04-24 22:54 ` Ritesh Harjani
2020-04-24 23:40 ` Matthew Wilcox [this message]
2020-04-24 23:46 ` Darrick J. Wong
2020-04-25 7:03 ` Ritesh Harjani
2020-04-27 1:04 ` Dave Chinner
2020-04-28 7:29 ` Ritesh Harjani
2020-04-24 7:22 ` [PATCH 2/2] iomap: bmap: Remove the WARN and return the proper block address Ritesh Harjani
2020-04-24 9:59 ` Jan Kara
2020-04-24 10:07 ` Christoph Hellwig
2020-04-24 17:48 ` Darrick J. Wong
2020-04-24 22:39 ` Ritesh Harjani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200424234058.GA29705@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=darrick.wong@oracle.com \
--cc=ebiggers@kernel.org \
--cc=hch@infradead.org \
--cc=jack@suse.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=riteshh@linux.ibm.com \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.