From: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
To: alsa-devel@alsa-project.org
Cc: tiwai@suse.de, broonie@kernel.org,
Bard Liao <yung-chuan.liao@linux.intel.com>,
pierre-louis.bossart@linux.intel.com,
kai.vehmanen@linux.intel.com
Subject: [PATCH 2/4] ASoC: topology: set component dai_index to ipc dai config dai_index
Date: Mon, 27 Apr 2020 10:29:37 -0700 [thread overview]
Message-ID: <20200427172939.25848-3-ranjani.sridharan@linux.intel.com> (raw)
In-Reply-To: <20200427172939.25848-1-ranjani.sridharan@linux.intel.com>
From: Bard Liao <yung-chuan.liao@linux.intel.com>
The ipc dai config dai_index is from topology. However, the same dai
config will be applied to all DAIs in the same dai link. We have to
ensure that the ipc dai config's dai_index match to the component's
dai_index.
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Reviewed-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
---
sound/soc/sof/topology.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/sound/soc/sof/topology.c b/sound/soc/sof/topology.c
index 0b15b4055f32..0ed3ab35e9f9 100644
--- a/sound/soc/sof/topology.c
+++ b/sound/soc/sof/topology.c
@@ -2693,6 +2693,14 @@ static int sof_set_dai_config(struct snd_sof_dev *sdev, u32 size,
struct sof_ipc_reply reply;
int ret;
+ /*
+ * the same dai config will be applied to all DAIs in
+ * the same dai link. We have to ensure that the ipc
+ * dai config's dai_index match to the component's
+ * dai_index.
+ */
+ config->dai_index = dai->comp_dai.dai_index;
+
/* send message to DSP */
ret = sof_ipc_tx_message(sdev->ipc,
config->hdr.cmd, config, size,
--
2.17.1
next prev parent reply other threads:[~2020-04-27 17:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-27 17:29 [PATCH 0/4] SOF topology parsing updates Ranjani Sridharan
2020-04-27 17:29 ` [PATCH 1/4] ASoC: SOF: topology: send ipc for all found DAIs in sof_set_dai_config Ranjani Sridharan
2020-04-27 17:29 ` Ranjani Sridharan [this message]
2020-04-27 17:29 ` [PATCH 3/4] ASoC: SOF: topology: replace sof_link_hda_process by sof_set_dai_config Ranjani Sridharan
2020-04-27 17:29 ` [PATCH 4/4] ASoC: SOF: Intel: change trigger sequence to fix pop noise when stopping playback on sdw platforms Ranjani Sridharan
2020-04-30 13:39 ` [PATCH 0/4] SOF topology parsing updates Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200427172939.25848-3-ranjani.sridharan@linux.intel.com \
--to=ranjani.sridharan@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=kai.vehmanen@linux.intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.de \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.