From: Denton Liu <liu.denton@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>, Git Mailing List <git@vger.kernel.org>,
Andrew White <andrew.white@audinate.com>
Subject: Re: [PATCH] push: unset PARSE_OPT_OPTARG for --recurse-submodules
Date: Tue, 28 Apr 2020 18:59:08 -0400 [thread overview]
Message-ID: <20200428225908.GA2570028@generichostname> (raw)
In-Reply-To: <xmqqwo5z33cz.fsf@gitster.c.googlers.com>
Hi Junio,
On Tue, Apr 28, 2020 at 10:51:56AM -0700, Junio C Hamano wrote:
> Here is what I am going to queue for this fix; hopefully it can be
> cherry-picked by folks who maintain older versions of Git for
> distros and in-house use.
>
> The other "huge" patch has also been adjusted by dropping the first
> hunk on builtin/push.c from it, and then resurrecting the part to
> use OPT_CALLBACK_F() for compare-and-swap (which happened to be in
> the same hunk).
Thanks, that approach makes sense to me. I looked at both patches that
you have queued and they look good.
-Denton
prev parent reply other threads:[~2020-04-28 22:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-27 1:31 Bug v2.23.0: command help for 'git push --recurse-submodules' is incorrect Andrew White
2020-04-27 6:44 ` [PATCH] push: unset PARSE_OPT_OPTARG for --recurse-submodules Denton Liu
2020-04-27 12:02 ` Jeff King
2020-04-27 18:54 ` Junio C Hamano
2020-04-28 8:36 ` [PATCH] Use OPT_CALLBACK and OPT_CALLBACK_F Denton Liu
2020-04-28 8:45 ` Jeff King
2020-04-28 17:34 ` Junio C Hamano
2020-04-28 17:51 ` [PATCH] push: unset PARSE_OPT_OPTARG for --recurse-submodules Junio C Hamano
2020-04-28 22:59 ` Denton Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200428225908.GA2570028@generichostname \
--to=liu.denton@gmail.com \
--cc=andrew.white@audinate.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.