Re: [PATCH 11/24] rcu/tree: Maintain separate array for vmalloc ptrs

From: kbuild test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH 11/24] rcu/tree: Maintain separate array for vmalloc ptrs
Date: Wed, 29 Apr 2020 13:11:22 +0800	[thread overview]
Message-ID: <202004291311.IyydeSPW%lkp@intel.com> (raw)
In-Reply-To: <20200428205903.61704-12-urezki@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 5191 bytes --]

Hi "Uladzislau,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on rcu/dev]
[also build test ERROR on rcu/rcu/next next-20200428]
[cannot apply to linus/master linux/master v5.7-rc3]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Uladzislau-Rezki-Sony/Introduce-kvfree_rcu-1-or-2-arguments/20200429-061752
base:   https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git dev
config: mips-loongson1c_defconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project f30416fdde922eaa655934e050026930fefbd260)
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install mips cross compiling tool for clang build
        # apt-get install binutils-mips-linux-gnu
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=mips 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> kernel/rcu/tree.c:3053:4: error: implicit declaration of function 'vfree' [-Werror,-Wimplicit-function-declaration]
                           vfree(bvhead->records[i]);
                           ^
   1 error generated.

vim +/vfree +3053 kernel/rcu/tree.c

  2989	
  2990	/*
  2991	 * This function is invoked in workqueue context after a grace period.
  2992	 * It frees all the objects queued on ->bhead_free or ->head_free.
  2993	 */
  2994	static void kfree_rcu_work(struct work_struct *work)
  2995	{
  2996		unsigned long flags;
  2997		struct kvfree_rcu_bulk_data *bkhead, *bvhead, *bnext;
  2998		struct rcu_head *head, *next;
  2999		struct kfree_rcu_cpu *krcp;
  3000		struct kfree_rcu_cpu_work *krwp;
  3001		int i;
  3002	
  3003		krwp = container_of(to_rcu_work(work),
  3004				    struct kfree_rcu_cpu_work, rcu_work);
  3005		krcp = krwp->krcp;
  3006	
  3007		raw_spin_lock_irqsave(&krcp->lock, flags);
  3008		/* Channel 1. */
  3009		bkhead = krwp->bkvhead_free[0];
  3010		krwp->bkvhead_free[0] = NULL;
  3011	
  3012		/* Channel 2. */
  3013		bvhead = krwp->bkvhead_free[1];
  3014		krwp->bkvhead_free[1] = NULL;
  3015	
  3016		/* Channel 3. */
  3017		head = krwp->head_free;
  3018		krwp->head_free = NULL;
  3019		raw_spin_unlock_irqrestore(&krcp->lock, flags);
  3020	
  3021		/* kmalloc()/kfree() channel. */
  3022		for (; bkhead; bkhead = bnext) {
  3023			bnext = bkhead->next;
  3024			debug_rcu_bhead_unqueue(bkhead);
  3025	
  3026			rcu_lock_acquire(&rcu_callback_map);
  3027			trace_rcu_invoke_kfree_bulk_callback(rcu_state.name,
  3028				bkhead->nr_records, bkhead->records);
  3029	
  3030			kfree_bulk(bkhead->nr_records, bkhead->records);
  3031			rcu_lock_release(&rcu_callback_map);
  3032	
  3033			krcp = krc_this_cpu_lock(&flags);
  3034			if (put_cached_bnode(krcp, bkhead))
  3035				bkhead = NULL;
  3036			krc_this_cpu_unlock(krcp, flags);
  3037	
  3038			if (bkhead)
  3039				free_page((unsigned long) bkhead);
  3040	
  3041			cond_resched_tasks_rcu_qs();
  3042		}
  3043	
  3044		/* vmalloc()/vfree() channel. */
  3045		for (; bvhead; bvhead = bnext) {
  3046			bnext = bvhead->next;
  3047			debug_rcu_bhead_unqueue(bvhead);
  3048	
  3049			rcu_lock_acquire(&rcu_callback_map);
  3050			for (i = 0; i < bvhead->nr_records; i++) {
  3051				trace_rcu_invoke_kfree_callback(rcu_state.name,
  3052					(struct rcu_head *) bvhead->records[i], 0);
> 3053				vfree(bvhead->records[i]);
  3054			}
  3055			rcu_lock_release(&rcu_callback_map);
  3056	
  3057			krcp = krc_this_cpu_lock(&flags);
  3058			if (put_cached_bnode(krcp, bvhead))
  3059				bvhead = NULL;
  3060			krc_this_cpu_unlock(krcp, flags);
  3061	
  3062			if (bvhead)
  3063				free_page((unsigned long) bvhead);
  3064	
  3065			cond_resched_tasks_rcu_qs();
  3066		}
  3067	
  3068		/*
  3069		 * Emergency case only. It can happen under low memory
  3070		 * condition when an allocation gets failed, so the "bulk"
  3071		 * path can not be temporary maintained.
  3072		 */
  3073		for (; head; head = next) {
  3074			unsigned long offset = (unsigned long)head->func;
  3075			void *ptr = (void *)head - offset;
  3076	
  3077			next = head->next;
  3078			debug_rcu_head_unqueue((struct rcu_head *)ptr);
  3079			rcu_lock_acquire(&rcu_callback_map);
  3080			trace_rcu_invoke_kfree_callback(rcu_state.name, head, offset);
  3081	
  3082			if (!WARN_ON_ONCE(!__is_kfree_rcu_offset(offset)))
  3083				kvfree(ptr);
  3084	
  3085			rcu_lock_release(&rcu_callback_map);
  3086			cond_resched_tasks_rcu_qs();
  3087		}
  3088	}
  3089	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 14790 bytes --]