From: Eric Biggers <ebiggers@kernel.org>
To: linux-crypto@vger.kernel.org
Subject: [PATCH 02/20] crypto: arm64/aes-glue - use crypto_shash_tfm_digest()
Date: Fri, 1 May 2020 22:31:04 -0700 [thread overview]
Message-ID: <20200502053122.995648-3-ebiggers@kernel.org> (raw)
In-Reply-To: <20200502053122.995648-1-ebiggers@kernel.org>
From: Eric Biggers <ebiggers@google.com>
Instead of manually allocating a 'struct shash_desc' on the stack and
calling crypto_shash_digest(), switch to using the new helper function
crypto_shash_tfm_digest() which does this for us.
Signed-off-by: Eric Biggers <ebiggers@google.com>
---
arch/arm64/crypto/aes-glue.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/arch/arm64/crypto/aes-glue.c b/arch/arm64/crypto/aes-glue.c
index ed5409c6abf4e9..395bbf64b2abb3 100644
--- a/arch/arm64/crypto/aes-glue.c
+++ b/arch/arm64/crypto/aes-glue.c
@@ -158,7 +158,6 @@ static int __maybe_unused essiv_cbc_set_key(struct crypto_skcipher *tfm,
unsigned int key_len)
{
struct crypto_aes_essiv_cbc_ctx *ctx = crypto_skcipher_ctx(tfm);
- SHASH_DESC_ON_STACK(desc, ctx->hash);
u8 digest[SHA256_DIGEST_SIZE];
int ret;
@@ -166,8 +165,7 @@ static int __maybe_unused essiv_cbc_set_key(struct crypto_skcipher *tfm,
if (ret)
return ret;
- desc->tfm = ctx->hash;
- crypto_shash_digest(desc, in_key, key_len, digest);
+ crypto_shash_tfm_digest(ctx->hash, in_key, key_len, digest);
return aes_expandkey(&ctx->key2, digest, sizeof(digest));
}
--
2.26.2
next prev parent reply other threads:[~2020-05-02 5:33 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-02 5:31 [PATCH 00/20] crypto: introduce crypto_shash_tfm_digest() Eric Biggers
2020-05-02 5:31 ` Eric Biggers
2020-05-02 5:31 ` Eric Biggers
2020-05-02 5:31 ` [PATCH 01/20] crypto: hash - " Eric Biggers
2020-05-02 5:31 ` Eric Biggers
2020-05-02 5:31 ` Eric Biggers
2020-05-02 5:31 ` Eric Biggers [this message]
2020-05-02 5:31 ` [PATCH 03/20] crypto: essiv - use crypto_shash_tfm_digest() Eric Biggers
2020-05-02 5:31 ` [PATCH 04/20] crypto: artpec6 " Eric Biggers
2020-05-02 5:31 ` [PATCH 05/20] crypto: ccp " Eric Biggers
2020-05-07 21:23 ` Tom Lendacky
2020-05-02 5:31 ` [PATCH 06/20] crypto: ccree " Eric Biggers
2020-05-03 14:01 ` Gilad Ben-Yossef
2020-05-02 5:31 ` [PATCH 07/20] crypto: hisilicon/sec2 " Eric Biggers
2020-05-02 5:31 ` [PATCH 08/20] crypto: mediatek " Eric Biggers
2020-05-02 5:31 ` [PATCH 09/20] crypto: n2 " Eric Biggers
2020-05-02 5:31 ` [PATCH 10/20] crypto: omap-sham " Eric Biggers
2020-05-02 5:31 ` [PATCH 11/20] crypto: s5p-sss " Eric Biggers
2020-05-05 14:19 ` Krzysztof Kozlowski
2020-05-02 5:31 ` [PATCH 12/20] nfc: s3fwrn5: " Eric Biggers
2020-05-02 5:31 ` [PATCH 13/20] fscrypt: " Eric Biggers
2020-05-02 5:31 ` [PATCH 14/20] ecryptfs: " Eric Biggers
2020-05-02 5:31 ` [PATCH 15/20] nfsd: " Eric Biggers
2020-05-04 19:09 ` J. Bruce Fields
2020-05-02 5:31 ` [PATCH 16/20] ubifs: " Eric Biggers
2020-05-02 5:31 ` Eric Biggers
2020-05-02 5:31 ` [PATCH 17/20] Bluetooth: " Eric Biggers
2020-05-02 5:31 ` [PATCH 18/20] sctp: " Eric Biggers
2020-05-02 5:31 ` Eric Biggers
2020-05-02 5:31 ` [PATCH 19/20] KEYS: encrypted: " Eric Biggers
2020-05-02 5:31 ` Eric Biggers
2020-05-02 5:31 ` [PATCH 20/20] ASoC: cros_ec_codec: " Eric Biggers
2020-05-02 6:44 ` [PATCH 00/20] crypto: introduce crypto_shash_tfm_digest() Marcel Holtmann
2020-05-02 6:44 ` Marcel Holtmann
2020-05-02 6:44 ` Marcel Holtmann
2020-05-03 16:13 ` Ard Biesheuvel
2020-05-03 16:13 ` Ard Biesheuvel
2020-05-03 16:13 ` Ard Biesheuvel
2020-05-08 6:07 ` Herbert Xu
2020-05-08 6:07 ` Herbert Xu
2020-05-08 6:07 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200502053122.995648-3-ebiggers@kernel.org \
--to=ebiggers@kernel.org \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.