From: Christoph Hellwig <hch@infradead.org>
To: Ming Lei <ming.lei@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Yufen Yu <yuyufen@huawei.com>,
Hou Tao <houtao1@huawei.com>
Subject: Re: [PATCH V2 4/4] block: don't hold part0's refcount in IO path
Date: Fri, 8 May 2020 00:47:00 -0700 [thread overview]
Message-ID: <20200508074700.GA27126@infradead.org> (raw)
In-Reply-To: <20200508074157.GA1375901@T590>
On Fri, May 08, 2020 at 03:41:57PM +0800, Ming Lei wrote:
> On Thu, May 07, 2020 at 11:41:33PM -0700, Christoph Hellwig wrote:
> > On Fri, May 08, 2020 at 12:44:07PM +0800, Ming Lei wrote:
> > > gendisk can't be gone when there is IO activity, so not hold
> > > part0's refcount in IO path.
> > >
> > > Cc: Yufen Yu <yuyufen@huawei.com>
> > > Cc: Christoph Hellwig <hch@infradead.org>
> > > Cc: Hou Tao <houtao1@huawei.com>
> > > Signed-off-by: Ming Lei <ming.lei@redhat.com>
> >
> > This looks correct, although I'd still prefer to centralize the
> > partno checks in the helpers. Also hd_struct_get is unused with
> > this patch isn't it?
>
> OK, are you fine with the following patch?
Yes, this looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2020-05-08 7:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-08 4:44 [PATCH V2 0/4] block: fix partition use-after-free and optimization Ming Lei
2020-05-08 4:44 ` [PATCH V2 1/4] block: fix use-after-free on cached last_lookup partition Ming Lei
2020-05-08 6:44 ` Christoph Hellwig
2020-05-08 4:44 ` [PATCH V2 2/4] block: only define 'nr_sects_seq' in hd_part for 32bit SMP Ming Lei
2020-05-08 4:44 ` [PATCH V2 3/4] block: re-organize fields of 'struct hd_part' Ming Lei
2020-05-08 4:44 ` [PATCH V2 4/4] block: don't hold part0's refcount in IO path Ming Lei
2020-05-08 6:41 ` Christoph Hellwig
2020-05-08 7:41 ` Ming Lei
2020-05-08 7:47 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200508074700.GA27126@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=houtao1@huawei.com \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=yuyufen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.