From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Raul E Rangel <rrangel@chromium.org>
Cc: Nehal-bakulchandra Shah <Nehal-bakulchandra.Shah@amd.com>,
linux-mmc@vger.kernel.org, evgreen@chromium.org,
Joerg Roedel <jroedel@suse.de>,
Daniel Kurtz <djkurtz@chromium.org>,
dianders@chromium.org, Ulf Hansson <ulf.hansson@linaro.org>,
Adrian Hunter <adrian.hunter@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mmc: sdhci-acpi: Add SDHCI_QUIRK2_BROKEN_64_BIT_DMA for AMDI0040
Date: Sat, 9 May 2020 14:26:19 +0300 [thread overview]
Message-ID: <20200509112619.GC185537@smile.fi.intel.com> (raw)
In-Reply-To: <20200508165344.1.Id5bb8b1ae7ea576f26f9d91c761df7ccffbf58c5@changeid>
On Fri, May 08, 2020 at 04:54:21PM -0600, Raul E Rangel wrote:
> The AMD eMMC 5.0 controller does not support 64 bit DMA.
>
> See the discussion here: https://marc.info/?l=linux-mmc&m=158879884514552&w=2
Link: ...
FWIW,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Fixes: 34597a3f60b1 ("mmc: sdhci-acpi: Add support for ACPI HID of AMD Controller with HS400")
> Signed-off-by: Raul E Rangel <rrangel@chromium.org>
> ---
>
> drivers/mmc/host/sdhci-acpi.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-acpi.c b/drivers/mmc/host/sdhci-acpi.c
> index faba53cf139b..d8b76cb8698a 100644
> --- a/drivers/mmc/host/sdhci-acpi.c
> +++ b/drivers/mmc/host/sdhci-acpi.c
> @@ -605,10 +605,12 @@ static int sdhci_acpi_emmc_amd_probe_slot(struct platform_device *pdev,
> }
>
> static const struct sdhci_acpi_slot sdhci_acpi_slot_amd_emmc = {
> - .chip = &sdhci_acpi_chip_amd,
> - .caps = MMC_CAP_8_BIT_DATA | MMC_CAP_NONREMOVABLE,
> - .quirks = SDHCI_QUIRK_32BIT_DMA_ADDR | SDHCI_QUIRK_32BIT_DMA_SIZE |
> - SDHCI_QUIRK_32BIT_ADMA_SIZE,
> + .chip = &sdhci_acpi_chip_amd,
> + .caps = MMC_CAP_8_BIT_DATA | MMC_CAP_NONREMOVABLE,
> + .quirks = SDHCI_QUIRK_32BIT_DMA_ADDR |
> + SDHCI_QUIRK_32BIT_DMA_SIZE |
> + SDHCI_QUIRK_32BIT_ADMA_SIZE,
> + .quirks2 = SDHCI_QUIRK2_BROKEN_64_BIT_DMA,
> .probe_slot = sdhci_acpi_emmc_amd_probe_slot,
> };
>
> --
> 2.26.2.645.ge9eca65c58-goog
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-05-09 11:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-08 22:54 [PATCH] mmc: sdhci-acpi: Add SDHCI_QUIRK2_BROKEN_64_BIT_DMA for AMDI0040 Raul E Rangel
2020-05-09 11:26 ` Andy Shevchenko [this message]
2020-05-10 11:33 ` Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200509112619.GC185537@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Nehal-bakulchandra.Shah@amd.com \
--cc=adrian.hunter@intel.com \
--cc=dianders@chromium.org \
--cc=djkurtz@chromium.org \
--cc=evgreen@chromium.org \
--cc=jroedel@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=rrangel@chromium.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.