Re: [PATCH 6/6] remote-curl: ensure last packet is a flush

From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Denton Liu <liu.denton@gmail.com>,
	Git Mailing List <git@vger.kernel.org>,
	Force Charlie <charlieio@outlook.com>,
	Jonathan Tan <jonathantanmy@google.com>,
	Jonathan Nieder <jrnieder@gmail.com>
Subject: Re: [PATCH 6/6] remote-curl: ensure last packet is a flush
Date: Mon, 18 May 2020 17:00:45 -0400	[thread overview]
Message-ID: <20200518210045.GA67802@coredump.intra.peff.net> (raw)
In-Reply-To: <20200518165206.GE42240@coredump.intra.peff.net>

On Mon, May 18, 2020 at 12:52:07PM -0400, Jeff King wrote:

> > I vaguely recall talking with somebody (perhaps it was Shawn Pearce)
> > about my long-time complaint on the on-the-wire protocol, in that
> > the protocol sometimes uses flush to merely mean "I've finished
> > speaking one section of my speech" and sometimes "I've done talking
> > for now and it's your turn to speak to me" (the receiving end needs
> > to know which one a particular flush means without knowing the
> > context in which it is issued---which makes it impossible to write a
> > protocol agnostic proxy.  
> > 
> > If the above proposal means that we'll have an explicit way to say
> > "Not just I am done with one section of my speech, but it is your
> > turn to speak and I am going to listen", that would be wonderful.
> 
> I think we already have that now in v2 because of the "0001" delim
> packet. All of the flushes are (I think) really "this is the end of my
> speech", and any inner "my list is ending, but I have more to say"
> delimiters are "0001".

Sadly, this is only _mostly_ true. See my response in:

  https://lore.kernel.org/git/20200518205854.GB63978@coredump.intra.peff.net/

-Peff