All of lore.kernel.org
 help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v3 11/14] ASoC: amd: enable Renoir acp3x drivers build
Date: Tue, 19 May 2020 19:59:16 +0800	[thread overview]
Message-ID: <202005191950.eIcpPpMP%lkp@intel.com> (raw)
In-Reply-To: <20200518171704.24999-12-Vijendar.Mukunda@amd.com>

[-- Attachment #1: Type: text/plain, Size: 4354 bytes --]

Hi Vijendar,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on asoc/for-next]
[also build test WARNING on v5.7-rc6 next-20200518]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Vijendar-Mukunda/Add-Renoir-ACP-driver/20200519-012848
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
config: i386-allyesconfig (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

All warnings (new ones prefixed by >>, old ones prefixed by <<):

sound/soc/amd/renoir/acp3x-pdm-dma.c: In function 'stop_pdm_dma':
>> sound/soc/amd/renoir/acp3x-pdm-dma.c:153:34: warning: variable 'pdm_fifo_flush' set but not used [-Wunused-but-set-variable]
u32 pdm_enable, pdm_dma_enable, pdm_fifo_flush;
^~~~~~~~~~~~~~

vim +/pdm_fifo_flush +153 sound/soc/amd/renoir/acp3x-pdm-dma.c

041ae75cda4ae70 Vijendar Mukunda 2020-05-19  150  
041ae75cda4ae70 Vijendar Mukunda 2020-05-19  151  static int stop_pdm_dma(void __iomem *acp_base)
041ae75cda4ae70 Vijendar Mukunda 2020-05-19  152  {
041ae75cda4ae70 Vijendar Mukunda 2020-05-19 @153  	u32 pdm_enable, pdm_dma_enable, pdm_fifo_flush;
041ae75cda4ae70 Vijendar Mukunda 2020-05-19  154  	int timeout;
041ae75cda4ae70 Vijendar Mukunda 2020-05-19  155  
041ae75cda4ae70 Vijendar Mukunda 2020-05-19  156  	pdm_enable = 0x00;
041ae75cda4ae70 Vijendar Mukunda 2020-05-19  157  	pdm_dma_enable  = 0x00;
041ae75cda4ae70 Vijendar Mukunda 2020-05-19  158  	pdm_fifo_flush = 0x00;
041ae75cda4ae70 Vijendar Mukunda 2020-05-19  159  
041ae75cda4ae70 Vijendar Mukunda 2020-05-19  160  	pdm_enable = rn_readl(acp_base + ACP_WOV_PDM_ENABLE);
041ae75cda4ae70 Vijendar Mukunda 2020-05-19  161  	pdm_dma_enable = rn_readl(acp_base + ACP_WOV_PDM_DMA_ENABLE);
041ae75cda4ae70 Vijendar Mukunda 2020-05-19  162  	if (pdm_dma_enable & 0x01) {
041ae75cda4ae70 Vijendar Mukunda 2020-05-19  163  		pdm_dma_enable = 0x02;
041ae75cda4ae70 Vijendar Mukunda 2020-05-19  164  		rn_writel(pdm_dma_enable, acp_base + ACP_WOV_PDM_DMA_ENABLE);
041ae75cda4ae70 Vijendar Mukunda 2020-05-19  165  		pdm_dma_enable = 0x00;
041ae75cda4ae70 Vijendar Mukunda 2020-05-19  166  		timeout = 0;
041ae75cda4ae70 Vijendar Mukunda 2020-05-19  167  		while (++timeout < ACP_COUNTER) {
041ae75cda4ae70 Vijendar Mukunda 2020-05-19  168  			pdm_dma_enable = rn_readl(acp_base +
041ae75cda4ae70 Vijendar Mukunda 2020-05-19  169  						  ACP_WOV_PDM_DMA_ENABLE);
041ae75cda4ae70 Vijendar Mukunda 2020-05-19  170  			if ((pdm_dma_enable & 0x02) == 0x00)
041ae75cda4ae70 Vijendar Mukunda 2020-05-19  171  				break;
041ae75cda4ae70 Vijendar Mukunda 2020-05-19  172  			udelay(DELAY_US);
041ae75cda4ae70 Vijendar Mukunda 2020-05-19  173  		}
041ae75cda4ae70 Vijendar Mukunda 2020-05-19  174  		if (timeout == ACP_COUNTER)
041ae75cda4ae70 Vijendar Mukunda 2020-05-19  175  			return -ETIMEDOUT;
041ae75cda4ae70 Vijendar Mukunda 2020-05-19  176  	}
041ae75cda4ae70 Vijendar Mukunda 2020-05-19  177  	if (pdm_enable == ACP_PDM_ENABLE) {
041ae75cda4ae70 Vijendar Mukunda 2020-05-19  178  		pdm_enable = ACP_PDM_DISABLE;
041ae75cda4ae70 Vijendar Mukunda 2020-05-19  179  		rn_writel(pdm_enable, acp_base + ACP_WOV_PDM_ENABLE);
041ae75cda4ae70 Vijendar Mukunda 2020-05-19  180  	}
041ae75cda4ae70 Vijendar Mukunda 2020-05-19  181  	rn_writel(0x01, acp_base + ACP_WOV_PDM_FIFO_FLUSH);
041ae75cda4ae70 Vijendar Mukunda 2020-05-19  182  	return 0;
041ae75cda4ae70 Vijendar Mukunda 2020-05-19  183  }
041ae75cda4ae70 Vijendar Mukunda 2020-05-19  184  

:::::: The code@line 153 was first introduced by commit
:::::: 041ae75cda4ae7035ab23ccf422dc5229871e720 ASoC: amd: add ACP PDM DMA driver dai ops

:::::: TO: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
:::::: CC: 0day robot <lkp@intel.com>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 72251 bytes --]

  reply	other threads:[~2020-05-19 11:59 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-18 17:16 [PATCH v3 00/14] Add Renoir ACP driver Vijendar Mukunda
2020-05-18 17:16 ` [PATCH v3 01/14] ASoC: amd: add Renoir ACP3x IP register header Vijendar Mukunda
2020-05-18 17:16 ` [PATCH v3 02/14] ASoC: amd: add Renoir ACP PCI driver Vijendar Mukunda
2020-05-18 17:16 ` [PATCH v3 03/14] ASoC: amd: add acp init/de-init functions Vijendar Mukunda
2020-05-18 17:16 ` [PATCH v3 04/14] ASoC: amd: create acp3x pdm platform device Vijendar Mukunda
2020-05-19 10:53   ` Mark Brown
2020-05-19 11:03     ` Mukunda, Vijendar
2020-05-19 14:40       ` Deucher, Alexander
2020-05-19 15:45         ` Mark Brown
2020-05-18 17:16 ` [PATCH v3 05/14] ASoC: amd: add ACP3x PDM platform driver Vijendar Mukunda
2020-05-19 10:54   ` Mark Brown
2020-05-19 11:10     ` Mukunda, Vijendar
2020-05-19 11:32       ` Mark Brown
2020-05-18 17:16 ` [PATCH v3 06/14] ASoC: amd: irq handler changes for ACP3x PDM dma driver Vijendar Mukunda
2020-05-18 17:16 ` [PATCH v3 07/14] ASoC: amd: add acp3x pdm driver dma ops Vijendar Mukunda
2020-05-18 17:16 ` [PATCH v3 08/14] ASoC: amd: add ACP PDM DMA driver dai ops Vijendar Mukunda
2020-05-19 11:19   ` Mark Brown
2020-05-19 11:37     ` Mukunda, Vijendar
2020-05-19 11:40       ` Mark Brown
2020-05-19 11:42         ` Mukunda, Vijendar
2020-05-18 17:16 ` [PATCH v3 09/14] ASoC: amd: add Renoir ACP PCI driver PM ops Vijendar Mukunda
2020-05-19 11:33   ` Mark Brown
2020-05-19 11:39     ` Mukunda, Vijendar
2020-05-18 17:17 ` [PATCH v3 10/14] ASoC: amd: add ACP PDM DMA driver pm ops Vijendar Mukunda
2020-05-18 17:17 ` [PATCH v3 11/14] ASoC: amd: enable Renoir acp3x drivers build Vijendar Mukunda
2020-05-19 11:59   ` kbuild test robot [this message]
2020-05-19 14:46     ` Mukunda, Vijendar
2020-05-18 17:17 ` [PATCH v3 12/14] ASoC: amd: create platform devices for Renoir Vijendar Mukunda
2020-05-18 17:17 ` [PATCH v3 13/14] ASoC: amd: RN machine driver using dmic Vijendar Mukunda
2020-05-18 17:17 ` [PATCH v3 14/14] ASoC: amd: enable build for RN machine driver Vijendar Mukunda
2020-05-18 17:31 ` [PATCH v3 00/14] Add Renoir ACP driver Pierre-Louis Bossart
2020-05-19 11:38 ` Mark Brown
2020-05-19 11:43   ` Mukunda, Vijendar
2020-05-19 12:45     ` Mukunda, Vijendar
2020-05-19 13:19 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202005191950.eIcpPpMP%lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild-all@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.