From: Serge Semin <Sergey.Semin@baikalelectronics.ru>
To: Mark Brown <broonie@kernel.org>
Cc: Serge Semin <fancer.lancer@gmail.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Georgy Vlasov <Georgy.Vlasov@baikalelectronics.ru>,
Ramil Zaripov <Ramil.Zaripov@baikalelectronics.ru>,
Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Paul Burton <paulburton@kernel.org>,
Ralf Baechle <ralf@linux-mips.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Arnd Bergmann <arnd@arndb.de>, Rob Herring <robh+dt@kernel.org>,
<linux-mips@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Wan Ahmad Zainie <wan.ahmad.zainie.wan.mohamad@intel.com>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Clement Leger <cleger@kalray.eu>,
linux-spi <linux-spi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 03/16] spi: dw: Discard static DW DMA slave structures
Date: Thu, 21 May 2020 18:58:04 +0300 [thread overview]
Message-ID: <20200521155804.qgaaqc23h2nll7r3@mobilestation> (raw)
In-Reply-To: <20200521155143.GE4770@sirena.org.uk>
On Thu, May 21, 2020 at 04:51:43PM +0100, Mark Brown wrote:
> On Thu, May 21, 2020 at 03:12:28PM +0300, Serge Semin wrote:
>
> > Well, for me both solutions are equal except mine consumes less stack memory.
> > The only reason why your solution might be better is that if DW DMA driver or
> > the DMA engine subsystem changed the dw_dma_slave structure instance passed to
> > the dma_request_channel() method, which non of them do. So I'll leave this for
> > Mark to decide. Mark, could you give us your final word about this?
>
> Honestly I'm struggling to care either way. I guess saving a bit of
> stack is potentially useful.
Settled then. Let's leave the patch as is. I suppose we've finally finished a
review except a question Feng asked to the patch:
[PATCH v3 01/16] spi: dw: Add Tx/Rx finish wait methods to the MID DMA
If you are ok with my responses, then the patchset is ready for you further
actions.
-Sergey
next prev parent reply other threads:[~2020-05-21 15:58 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-21 1:21 [PATCH v3 00/16] spi: dw: Add generic DW DMA controller support Serge Semin
2020-05-21 1:21 ` [PATCH v3 01/16] spi: dw: Add Tx/Rx finish wait methods to the MID DMA Serge Semin
2020-05-21 3:09 ` Feng Tang
2020-05-21 11:47 ` Serge Semin
2020-05-21 14:55 ` Feng Tang
2020-05-21 15:33 ` Serge Semin
2020-05-22 7:58 ` Feng Tang
2020-05-22 11:32 ` Serge Semin
2020-05-22 12:03 ` Feng Tang
2020-05-22 12:25 ` Serge Semin
2020-05-21 23:33 ` Serge Semin
2020-05-21 1:21 ` [PATCH v3 02/16] spi: dw: Enable interrupts in accordance with DMA xfer mode Serge Semin
2020-05-21 1:21 ` [PATCH v3 03/16] spi: dw: Discard static DW DMA slave structures Serge Semin
2020-05-21 9:57 ` Andy Shevchenko
[not found] ` <20200521121228.aqplh6eftylnys3p@mobilestation>
2020-05-21 12:49 ` Andy Shevchenko
2020-05-21 15:51 ` Mark Brown
2020-05-21 15:56 ` Andy Shevchenko
2020-05-21 15:58 ` Serge Semin [this message]
2020-05-21 16:02 ` Andy Shevchenko
2020-05-21 16:39 ` Mark Brown
2020-05-21 16:44 ` Andy Shevchenko
2020-05-21 17:29 ` Serge Semin
2020-05-21 1:21 ` [PATCH v3 06/16] spi: dw: Parameterize the DMA Rx/Tx burst length Serge Semin
2020-05-21 10:23 ` Andy Shevchenko
2020-05-21 1:21 ` [PATCH v3 07/16] spi: dw: Use DMA max burst to set the request thresholds Serge Semin
2020-05-21 10:49 ` Andy Shevchenko
2020-05-21 1:22 ` [PATCH v3 11/16] spi: dw: Remove DW DMA code dependency from DW_DMAC_PCI Serge Semin
2020-05-21 1:22 ` [PATCH v3 12/16] spi: dw: Add DW SPI DMA/PCI/MMIO dependency on the DW SPI core Serge Semin
2020-05-21 1:22 ` [PATCH v3 14/16] spi: dw: Add DMA support to the DW SPI MMIO driver Serge Semin
2020-05-21 1:22 ` [PATCH v3 16/16] dt-bindings: spi: Convert DW SPI binding to DT schema Serge Semin
[not found] ` <20200521012206.14472-10-Sergey.Semin@baikalelectronics.ru>
2020-05-21 10:47 ` [PATCH v3 09/16] spi: dw: Add core suffix to the DW APB SSI core source file Andy Shevchenko
2020-05-21 17:46 ` [PATCH v3 00/16] spi: dw: Add generic DW DMA controller support Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200521155804.qgaaqc23h2nll7r3@mobilestation \
--to=sergey.semin@baikalelectronics.ru \
--cc=Alexey.Malahov@baikalelectronics.ru \
--cc=Georgy.Vlasov@baikalelectronics.ru \
--cc=Ramil.Zaripov@baikalelectronics.ru \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=cleger@kalray.eu \
--cc=devicetree@vger.kernel.org \
--cc=fancer.lancer@gmail.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=paulburton@kernel.org \
--cc=ralf@linux-mips.org \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
--cc=tsbogend@alpha.franken.de \
--cc=wan.ahmad.zainie.wan.mohamad@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.