All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>
Cc: dsterba@suse.cz, Qu Wenruo <wqu@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: relocation: Fix reloc root leakage and the NULL pointer reference caused by the leakage
Date: Fri, 22 May 2020 15:50:36 +0200	[thread overview]
Message-ID: <20200522135035.GM18421@twin.jikos.cz> (raw)
In-Reply-To: <49d73606-df91-d030-cb70-c34796c792b3@gmx.com>

On Wed, May 20, 2020 at 07:00:26AM +0800, Qu Wenruo wrote:
> >> [FIX]
> >> The fix is to clear fs_root->reloc_root and put it at
> >> merge_reloc_roots() time, so that we won't leak reloc roots.
> >>
> >> Fixes: d2311e698578 ("btrfs: relocation: Delay reloc tree deletion after merge_reloc_roots")
> > 
> > Thanks. I've applied it before my cleanups (read_fs_root) but the fix
> > still depends on the refcounted root trees so it's no applicable to any
> > older stable trees.
> > 
> No problem, I would craft fixes for older branches.
> 
> But for that case, what's the proper tags to specify the stable kernel
> ranges?

I've added the "CC: stable@" tags to the applied patches, they'll fail
to apply once picked by stable team, and then we need the backports.
Which means use the upstram patches, resolve the conflicts (ie. only
code changes) and then send it to stable@. The tags don't need to be
updaated.

      reply	other threads:[~2020-05-22 13:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-19  2:13 [PATCH] btrfs: relocation: Fix reloc root leakage and the NULL pointer reference caused by the leakage Qu Wenruo
2020-05-19  2:14 ` Qu Wenruo
2020-05-19  9:13 ` Johannes Thumshirn
2020-05-19 14:04 ` David Sterba
2020-05-19 23:00   ` Qu Wenruo
2020-05-22 13:50     ` David Sterba [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200522135035.GM18421@twin.jikos.cz \
    --to=dsterba@suse.cz \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=quwenruo.btrfs@gmx.com \
    --cc=wqu@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.