Re: [PATCH rdma-next v2 5/7] RDMA/cm: Send and receive ECE parameter over the wire

From: Jason Gunthorpe <jgg@ziepe.ca>
To: Leon Romanovsky <leon@kernel.org>
Cc: Doug Ledford <dledford@redhat.com>,
	Leon Romanovsky <leonro@mellanox.com>,
	linux-rdma@vger.kernel.org
Subject: Re: [PATCH rdma-next v2 5/7] RDMA/cm: Send and receive ECE parameter over the wire
Date: Mon, 25 May 2020 14:58:12 -0300	[thread overview]
Message-ID: <20200525175812.GB24366@ziepe.ca> (raw)
In-Reply-To: <20200413141538.935574-6-leon@kernel.org>

On Mon, Apr 13, 2020 at 05:15:36PM +0300, Leon Romanovsky wrote:
> @@ -2204,6 +2220,12 @@ static void cm_format_rep(struct cm_rep_msg *rep_msg,
>  		IBA_SET(CM_REP_LOCAL_EE_CONTEXT_NUMBER, rep_msg, param->qp_num);
>  	}
>  
> +	IBA_SET(CM_REP_VENDOR_ID_L, rep_msg, param->ece.vendor_id & 0xFF);
> +	IBA_SET(CM_REP_VENDOR_ID_M, rep_msg,
> +		(param->ece.vendor_id >> 8) & 0xFF);
> +	IBA_SET(CM_REP_VENDOR_ID_H, rep_msg,
> +		(param->ece.vendor_id >> 16) & 0xFF);

I'm pretty sure the & 0xFF isn't needed?

> diff --git a/drivers/infiniband/core/ucma.c b/drivers/infiniband/core/ucma.c
> index ed2c17046ee1..b67cdd2ef187 100644
> +++ b/drivers/infiniband/core/ucma.c
> @@ -362,7 +362,6 @@ static int ucma_event_handler(struct rdma_cm_id *cm_id,
>  
>  	uevent->resp.ece.vendor_id = event->ece.vendor_id;
>  	uevent->resp.ece.attr_mod = event->ece.attr_mod;
> -
>  	if (event->event == RDMA_CM_EVENT_CONNECT_REQUEST) {
>  		if (!ctx->backlog) {
>  			ret = -ENOMEM;

Extra hunk?

Jason