From: Leon Romanovsky <leon@kernel.org>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Doug Ledford <dledford@redhat.com>, linux-rdma@vger.kernel.org
Subject: Re: [PATCH rdma-next v1 7/9] RDMA/mlx5: Advertise ECE support
Date: Mon, 25 May 2020 21:29:12 +0300 [thread overview]
Message-ID: <20200525182912.GN10591@unreal> (raw)
In-Reply-To: <20200525181845.GE24366@ziepe.ca>
On Mon, May 25, 2020 at 03:18:45PM -0300, Jason Gunthorpe wrote:
> On Sat, May 23, 2020 at 04:22:41PM +0300, Leon Romanovsky wrote:
> > From: Leon Romanovsky <leonro@mellanox.com>
> >
> > The ECE bits are configured through create_qp and modify_qp commands.
> > While the create_qp() can be easily extended, it is not an easy task
> > for the modify_qp().
> >
> > The new bit in the comp_mask is needed to mark that kernel supports
> > ECE and can receive data instead of "reserved" field in the
> > struct mlx5_ib_modify_qp.
> >
> > Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
> > drivers/infiniband/hw/mlx5/main.c | 3 +++
> > include/uapi/rdma/mlx5-abi.h | 1 +
> > 2 files changed, 4 insertions(+)
> >
> > diff --git a/drivers/infiniband/hw/mlx5/main.c b/drivers/infiniband/hw/mlx5/main.c
> > index 6094ab2f4cd7..570c519ca530 100644
> > +++ b/drivers/infiniband/hw/mlx5/main.c
> > @@ -1971,6 +1971,9 @@ static int mlx5_ib_alloc_ucontext(struct ib_ucontext *uctx,
> > resp.response_length += sizeof(resp.dump_fill_mkey);
> > }
> >
> > + if (MLX5_CAP_GEN(dev->mdev, ece_support))
> > + resp.comp_mask |= MLX5_IB_ALLOC_UCONTEXT_RESP_MASK_ECE;
> > +
> > err = ib_copy_to_udata(udata, &resp, resp.response_length);
> > if (err)
> > goto out_mdev;
> > diff --git a/include/uapi/rdma/mlx5-abi.h b/include/uapi/rdma/mlx5-abi.h
> > index bc9d9e3cb369..90ea1e5aa291 100644
> > +++ b/include/uapi/rdma/mlx5-abi.h
> > @@ -100,6 +100,7 @@ struct mlx5_ib_alloc_ucontext_req_v2 {
> > enum mlx5_ib_alloc_ucontext_resp_mask {
> > MLX5_IB_ALLOC_UCONTEXT_RESP_MASK_CORE_CLOCK_OFFSET = 1UL << 0,
> > MLX5_IB_ALLOC_UCONTEXT_RESP_MASK_DUMP_FILL_MKEY = 1UL << 1,
> > + MLX5_IB_ALLOC_UCONTEXT_RESP_MASK_ECE = 1UL << 2,
> > };
>
> This should be squashed into the patch overriding the reserved field
ok
>
> Jason
next prev parent reply other threads:[~2020-05-25 18:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-23 13:22 [PATCH rdma-next v1 0/9] Driver part of the ECE Leon Romanovsky
2020-05-23 13:22 ` [PATCH mlx5-next v1 1/9] net/mlx5: Add ability to read and write ECE options Leon Romanovsky
2020-05-23 13:22 ` [PATCH rdma-next v1 2/9] RDMA/mlx5: Get ECE options from FW during create QP Leon Romanovsky
2020-05-25 18:17 ` Jason Gunthorpe
2020-05-25 18:27 ` Leon Romanovsky
2020-05-23 13:22 ` [PATCH rdma-next v1 3/9] RDMA/mlx5: Set ECE options during QP create Leon Romanovsky
2020-05-23 13:22 ` [PATCH rdma-next v1 4/9] RDMA/mlx5: Use direct modify QP implementation Leon Romanovsky
2020-05-23 13:22 ` [PATCH rdma-next v1 5/9] RDMA/mlx5: Remove manually crafted QP context the query call Leon Romanovsky
2020-05-23 13:22 ` [PATCH rdma-next v1 6/9] RDMA/mlx5: Convert modify QP to use MLX5_SET macros Leon Romanovsky
2020-05-23 13:22 ` [PATCH rdma-next v1 7/9] RDMA/mlx5: Advertise ECE support Leon Romanovsky
2020-05-25 18:18 ` Jason Gunthorpe
2020-05-25 18:29 ` Leon Romanovsky [this message]
2020-05-23 13:22 ` [PATCH rdma-next v1 8/9] RDMA/mlx5: Set ECE options during modify QP Leon Romanovsky
2020-05-23 13:22 ` [PATCH rdma-next v1 9/9] RDMA/mlx5: Return ECE data after " Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200525182912.GN10591@unreal \
--to=leon@kernel.org \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.