From: Serge Semin <Sergey.Semin@baikalelectronics.ru>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Serge Semin <Sergey.Semin@baikalelectronics.ru>,
Serge Semin <fancer.lancer@gmail.com>,
Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>,
Olof Johansson <olof@lixom.net>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
<soc@kernel.org>, <linux-kernel@vger.kernel.org>
Subject: [PATCH 3/6] bus: bt1-apb: Use PTR_ERR_OR_ZERO to return from request-regs method
Date: Thu, 28 May 2020 17:50:47 +0300 [thread overview]
Message-ID: <20200528145050.5203-3-Sergey.Semin@baikalelectronics.ru> (raw)
In-Reply-To: <20200528145050.5203-1-Sergey.Semin@baikalelectronics.ru>
Indeed it's more optimal to use the PTR_ERR_OR_ZERO() macro there instead
of having two return points.
Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
Cc: Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>
Cc: Olof Johansson <olof@lixom.net>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: soc@kernel.org
---
drivers/bus/bt1-apb.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/bus/bt1-apb.c b/drivers/bus/bt1-apb.c
index 59ec5e7077e8..7e57fc2af745 100644
--- a/drivers/bus/bt1-apb.c
+++ b/drivers/bus/bt1-apb.c
@@ -164,12 +164,10 @@ static int bt1_apb_request_regs(struct bt1_apb *apb)
}
apb->res = devm_platform_ioremap_resource_byname(pdev, "nodev");
- if (IS_ERR(apb->res)) {
+ if (IS_ERR(apb->res))
dev_err(apb->dev, "Couldn't map reserved region\n");
- return PTR_ERR(apb->res);
- }
- return 0;
+ return PTR_ERR_OR_ZERO(apb->res);
}
static int bt1_apb_request_rst(struct bt1_apb *apb)
--
2.26.2
next prev parent reply other threads:[~2020-05-28 14:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-28 14:50 [PATCH 1/6] bus: bt1-apb: Include linux/io.h Serge Semin
2020-05-28 14:50 ` [PATCH 2/6] bus: bt1-apb: Fix show/store callback identations Serge Semin
2020-05-28 14:50 ` Serge Semin [this message]
2020-05-28 14:50 ` [PATCH 4/6] bus: bt1-apb: Use sysfs_streq instead of strncmp Serge Semin
2020-05-28 14:50 ` [PATCH 5/6] bus: bt1-axi: Optimize the return points in the driver Serge Semin
2020-05-28 14:50 ` [PATCH 6/6] bus: bt1-axi: Use sysfs_streq instead of strncmp Serge Semin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200528145050.5203-3-Sergey.Semin@baikalelectronics.ru \
--to=sergey.semin@baikalelectronics.ru \
--cc=Alexey.Malahov@baikalelectronics.ru \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=fancer.lancer@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.