From: Ming Lei <ming.lei@redhat.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org,
Damien Le Moal <Damien.LeMoal@wdc.com>,
Ming Lei <ming.lei@redhat.com>, Sagi Grimberg <sagi@grimberg.me>,
Baolin Wang <baolin.wang7@gmail.com>,
Christoph Hellwig <hch@infradead.org>
Subject: [PATCH V5 4/6] blk-mq: remove dead check from blk_mq_dispatch_rq_list
Date: Wed, 3 Jun 2020 17:43:35 +0800 [thread overview]
Message-ID: <20200603094337.2064181-5-ming.lei@redhat.com> (raw)
In-Reply-To: <20200603094337.2064181-1-ming.lei@redhat.com>
When BLK_STS_RESOURCE or BLK_STS_DEV_RESOURCE is returned from
.queue_rq, the 'list' variable always holds this rq which isn't
queued to LLD successfully.
So blk_mq_dispatch_rq_list() always returns false from the branch
of '!list_empty(list)'.
No functional change.
Cc: Sagi Grimberg <sagi@grimberg.me>
Cc: Baolin Wang <baolin.wang7@gmail.com>
Cc: Christoph Hellwig <hch@infradead.org>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Reviewed-by: Christoph Hellwig <hch@infradead.org>
Tested-by: Baolin Wang <baolin.wang7@gmail.com>
Signed-off-by: Ming Lei <ming.lei@redhat.com>
---
block/blk-mq.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/block/blk-mq.c b/block/blk-mq.c
index fbfdb455e613..4085dc59bea6 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -1404,13 +1404,6 @@ bool blk_mq_dispatch_rq_list(struct blk_mq_hw_ctx *hctx, struct list_head *list,
} else
blk_mq_update_dispatch_busy(hctx, false);
- /*
- * If the host/device is unable to accept more work, inform the
- * caller of that.
- */
- if (ret == BLK_STS_RESOURCE || ret == BLK_STS_DEV_RESOURCE)
- return false;
-
return (queued + errors) != 0;
}
--
2.25.2
next prev parent reply other threads:[~2020-06-03 9:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-03 9:43 [PATCH V5 0/6] blk-mq: support batching dispatch from scheduler Ming Lei
2020-06-03 9:43 ` [PATCH V5 1/6] blk-mq: pass request queue into get/put budget callback Ming Lei
2020-06-03 9:43 ` [PATCH V5 2/6] blk-mq: pass hctx to blk_mq_dispatch_rq_list Ming Lei
2020-06-03 9:43 ` [PATCH V5 3/6] blk-mq: move getting driver tag and budget into one helper Ming Lei
2020-06-03 9:43 ` Ming Lei [this message]
2020-06-03 9:43 ` [PATCH V5 5/6] blk-mq: pass obtained budget count to blk_mq_dispatch_rq_list Ming Lei
2020-06-03 9:43 ` [PATCH V5 6/6] blk-mq: support batching dispatch in case of io scheduler Ming Lei
2020-06-24 21:17 ` [PATCH V5 0/6] blk-mq: support batching dispatch from scheduler Sagi Grimberg
2020-06-24 22:58 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200603094337.2064181-5-ming.lei@redhat.com \
--to=ming.lei@redhat.com \
--cc=Damien.LeMoal@wdc.com \
--cc=axboe@kernel.dk \
--cc=baolin.wang7@gmail.com \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.