From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Kees Cook <keescook@chromium.org>
Cc: Thierry Reding <thierry.reding@gmail.com>,
linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org
Subject: Re: [PATCH] pwm: Add missing "CONFIG_" prefix
Date: Thu, 4 Jun 2020 16:43:04 +0200 [thread overview]
Message-ID: <20200604144304.jxbauv5xy4uj55es@pengutronix.de> (raw)
In-Reply-To: <202006031539.4198EA6@keescook>
On Wed, Jun 03, 2020 at 03:40:56PM -0700, Kees Cook wrote:
> The IS_ENABLED() use was missing the CONFIG_ prefix which would have
> lead to skipping this code.
>
> Fixes: 3ad1f3a33286 ("pwm: Implement some checks for lowlevel drivers")
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
> drivers/pwm/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c
> index 9973c442b455..6b3cbc0490c6 100644
> --- a/drivers/pwm/core.c
> +++ b/drivers/pwm/core.c
> @@ -121,7 +121,7 @@ static int pwm_device_request(struct pwm_device *pwm, const char *label)
> pwm->chip->ops->get_state(pwm->chip, pwm, &pwm->state);
> trace_pwm_get(pwm, &pwm->state);
>
> - if (IS_ENABLED(PWM_DEBUG))
> + if (IS_ENABLED(CONFIG_PWM_DEBUG))
> pwm->last = pwm->state;
Thanks
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
next prev parent reply other threads:[~2020-06-04 14:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-03 22:40 [PATCH] pwm: Add missing "CONFIG_" prefix Kees Cook
2020-06-03 23:04 ` Joe Perches
2020-06-03 23:04 ` Joe Perches
2020-06-03 23:38 ` Kees Cook
2020-06-03 23:38 ` Kees Cook
2020-06-04 21:52 ` Kees Cook
2020-06-04 21:52 ` Kees Cook
2020-06-05 4:07 ` Joe Perches
2020-06-05 4:07 ` Joe Perches
2020-06-04 14:43 ` Uwe Kleine-König [this message]
2020-06-04 17:16 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200604144304.jxbauv5xy4uj55es@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.