From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Alistair Francis" <alistair.francis@wdc.com>,
"Richard Henderson" <rth@twiddle.net>
Subject: [PATCH v5 06/11] Makefile: Remove dangerous EOL trailing backslash
Date: Fri, 5 Jun 2020 09:39:48 +0200 [thread overview]
Message-ID: <20200605073953.19268-7-philmd@redhat.com> (raw)
In-Reply-To: <20200605073953.19268-1-philmd@redhat.com>
One might get caught trying to understand unexpected Makefile
behavior. Trailing backslash can help to split very long lines,
but are rather dangerous when nothing follow. Preserve other
developers debugging time by removing this one.
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index 40e4f7677b..6c9d718b2c 100644
--- a/Makefile
+++ b/Makefile
@@ -420,7 +420,7 @@ MINIKCONF_ARGS = \
MINIKCONF_INPUTS = $(SRC_PATH)/Kconfig.host $(SRC_PATH)/hw/Kconfig
MINIKCONF_DEPS = $(MINIKCONF_INPUTS) $(wildcard $(SRC_PATH)/hw/*/Kconfig)
-MINIKCONF = $(PYTHON) $(SRC_PATH)/scripts/minikconf.py \
+MINIKCONF = $(PYTHON) $(SRC_PATH)/scripts/minikconf.py
$(SUBDIR_DEVICES_MAK): %/config-devices.mak: default-configs/%.mak $(MINIKCONF_DEPS) $(BUILD_DIR)/config-host.mak
$(call quiet-command, $(MINIKCONF) $(MINIKCONF_ARGS) > $@.tmp, "GEN", "$@.tmp")
--
2.21.3
next prev parent reply other threads:[~2020-06-05 7:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-05 7:39 [PATCH v5 00/11] accel: Allow targets to use Kconfig Philippe Mathieu-Daudé
2020-06-05 7:39 ` [PATCH v5 01/11] MAINTAINERS: Fix KVM path expansion glob Philippe Mathieu-Daudé
2020-06-05 7:39 ` [PATCH v5 02/11] MAINTAINERS: Add an 'overall' entry for accelerators Philippe Mathieu-Daudé
2020-06-05 7:39 ` [PATCH v5 03/11] MAINTAINERS: Add an entry for the HAX accelerator Philippe Mathieu-Daudé
2020-06-05 8:35 ` Philippe Mathieu-Daudé
2020-06-05 7:39 ` [PATCH v5 04/11] rules.mak: Add strequal() and startwith() and rules Philippe Mathieu-Daudé
2020-06-05 7:42 ` Philippe Mathieu-Daudé
2020-06-05 12:48 ` Markus Armbruster
2020-06-05 12:53 ` Philippe Mathieu-Daudé
2020-06-05 7:39 ` [PATCH v5 05/11] rules.mak: Add base-arch() rule Philippe Mathieu-Daudé
2020-06-05 7:39 ` Philippe Mathieu-Daudé [this message]
2020-06-05 7:39 ` [PATCH v5 07/11] Makefile: Write MINIKCONF variables as one entry per line Philippe Mathieu-Daudé
2020-06-05 7:39 ` [PATCH v5 08/11] accel/Kconfig: Extract accel selectors into their own config Philippe Mathieu-Daudé
2020-06-05 7:39 ` [PATCH v5 09/11] accel/Kconfig: Add the TCG selector Philippe Mathieu-Daudé
2020-06-05 7:39 ` [PATCH v5 10/11] Makefile: Allow target-specific optional Kconfig Philippe Mathieu-Daudé
2020-06-05 7:39 ` [PATCH v5 11/11] accel/tcg: Add stub for probe_access() Philippe Mathieu-Daudé
2020-06-05 7:45 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200605073953.19268-7-philmd@redhat.com \
--to=philmd@redhat.com \
--cc=alistair.francis@wdc.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.