Re: [PATCH 20/32] iio:imu:inv_mpu6050 Fix dma and ts alignment and data leak issues.

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Jean-Baptiste Maneyrol <JManeyrol@invensense.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
	"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	Lars-Peter Clausen <lars@metafoo.de>
Subject: Re: [PATCH 20/32] iio:imu:inv_mpu6050 Fix dma and ts alignment and data leak issues.
Date: Mon, 8 Jun 2020 13:42:10 +0300	[thread overview]
Message-ID: <20200608104210.GH2428291@smile.fi.intel.com> (raw)
In-Reply-To: <MN2PR12MB44220F9CE7BDF5ACA3DEF4A4C4850@MN2PR12MB4422.namprd12.prod.outlook.com>

On Mon, Jun 08, 2020 at 10:24:11AM +0000, Jean-Baptiste Maneyrol wrote:
> Hi Jonathan,
> 
> as stated before, I think this is a good opportunity to fix FIFO data reading by replacing regmap_bulk_read by regmap_noinc_read.
> Otherwise it could also be done in another patch.

It seems I didn't get this series to my work email, so, sorry for answering here.

> -       result = regmap_bulk_read(st->map, st->reg->fifo_count_h, data,
> +       result = regmap_bulk_read(st->map, st->reg->fifo_count_h,

> +                                 st->data,
>                                    INV_MPU6050_FIFO_COUNT_BYTE);

Now this can be one line :-)

...

> -               iio_push_to_buffers_with_timestamp(indio_dev, data, timestamp);
> +               iio_push_to_buffers_with_timestamp(indio_dev, st->data,
> +                                                  timestamp);

And this seems redundant change.

-- 
With Best Regards,
Andy Shevchenko