All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: stable@vger.kernel.org, Roi Dayan <roid@mellanox.com>,
	Mark Bloch <markb@mellanox.com>,
	Saeed Mahameed <saeedm@mellanox.com>
Subject: Re: Possible linux-stable mis-backport in ethernet/mellanox/mlx5
Date: Tue, 9 Jun 2020 19:29:07 +0200	[thread overview]
Message-ID: <20200609172907.GA873279@kroah.com> (raw)
In-Reply-To: <20200607203425.GD23662@windriver.com>

On Sun, Jun 07, 2020 at 04:34:25PM -0400, Paul Gortmaker wrote:
> I happened to notice this commit:
> 
> 9ca415399dae - "net/mlx5: Annotate mutex destroy for root ns"
> 
> ...was backported to 4.19 and 5.4 and v5.6 in linux-stable.
> 
> It patches del_sw_root_ns() - which only exists after v5.7-rc7 from:
> 
> 6eb7a268a99b - "net/mlx5: Don't maintain a case of del_sw_func being
> null"
> 
> which creates the one line del_sw_root_ns stub function around
> kfree(node) by breaking it out of tree_put_node().
> 
> In the absense of del_sw_root_ns - the backport finds an identical one
> line kfree stub fcn - named del_sw_prio from this earlier commit:
> 
> 139ed6c6c46a - "net/mlx5: Fix steering memory leak"  [in v4.15-rc5]
> 
> and then puts the mutex_destroy() into that (wrong) function, instead of
> putting it into tree_put_node where the root ns case used to be handled.

Ugh, good catch.  I'll go revert this from everywhere.  If you could,
can you provide a working backport?

thanks,

greg k-h

  reply	other threads:[~2020-06-09 17:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-07 20:34 Possible linux-stable mis-backport in ethernet/mellanox/mlx5 Paul Gortmaker
2020-06-09 17:29 ` Greg Kroah-Hartman [this message]
2020-06-10 17:26   ` Paul Gortmaker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200609172907.GA873279@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=markb@mellanox.com \
    --cc=paul.gortmaker@windriver.com \
    --cc=roid@mellanox.com \
    --cc=saeedm@mellanox.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.