From: Christoph Hellwig <hch@infradead.org>
To: Ritesh Harjani <riteshh@linux.ibm.com>
Cc: linux-ext4@vger.kernel.org, jack@suse.com, tytso@mit.edu,
Hillf Danton <hdanton@sina.com>,
linux-fsdevel@vger.kernel.org, Borislav Petkov <bp@alien8.de>,
Marek Szyprowski <m.szyprowski@samsung.com>,
syzbot+82f324bb69744c5f6969@syzkaller.appspotmail.com
Subject: Re: [PATCHv2 1/1] ext4: mballoc: Use this_cpu_read instead of this_cpu_ptr
Date: Tue, 9 Jun 2020 23:25:38 -0700 [thread overview]
Message-ID: <20200610062538.GA24975@infradead.org> (raw)
In-Reply-To: <534f275016296996f54ecf65168bb3392b6f653d.1591699601.git.riteshh@linux.ibm.com>
On Tue, Jun 09, 2020 at 04:23:10PM +0530, Ritesh Harjani wrote:
> Simplify reading a seq variable by directly using this_cpu_read API
> instead of doing this_cpu_ptr and then dereferencing it.
>
> This also avoid the below kernel BUG: which happens when
> CONFIG_DEBUG_PREEMPT is enabled
I see this warning all the time with ext4 using tests VMs, so lets get
this fixed ASAP before -rc1:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2020-06-10 6:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-09 10:53 [PATCHv2 1/1] ext4: mballoc: Use this_cpu_read instead of this_cpu_ptr Ritesh Harjani
2020-06-10 6:25 ` Christoph Hellwig [this message]
2020-06-10 6:34 ` Ritesh Harjani
2020-06-11 15:03 ` Theodore Y. Ts'o
[not found] <20200609123716.16888-1-hdanton@sina.com>
2020-06-10 2:06 ` Ritesh Harjani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200610062538.GA24975@infradead.org \
--to=hch@infradead.org \
--cc=bp@alien8.de \
--cc=hdanton@sina.com \
--cc=jack@suse.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=riteshh@linux.ibm.com \
--cc=syzbot+82f324bb69744c5f6969@syzkaller.appspotmail.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.