From: Christoph Hellwig <hch@infradead.org>
To: Piotr Stankiewicz <piotr.stankiewicz@intel.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
Andrew Murray <amurray@thegoodpenguin.co.uk>,
Logan Gunthorpe <logang@deltatee.com>,
Andy Shevchenko <andriy.shevchenko@intel.com>,
Zenghui Yu <yuzenghui@huawei.com>,
Kelsey Skunberg <skunberg.kelsey@gmail.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Krzysztof Wilczynski <kw@linux.com>,
Kuppuswamy Sathyanarayanan
<sathyanarayanan.kuppuswamy@linux.intel.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Yicong Yang <yangyicong@hisilicon.com>,
Denis Efremov <efremov@linux.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 02/15] PCI: Add macro for message signalled interrupt types
Date: Wed, 10 Jun 2020 00:08:28 -0700 [thread overview]
Message-ID: <20200610070828.GA29678@infradead.org> (raw)
In-Reply-To: <20200609162243.9102-1-piotr.stankiewicz@intel.com>
On Tue, Jun 09, 2020 at 06:22:40PM +0200, Piotr Stankiewicz wrote:
> There are several places in the kernel which check/ask for MSI or MSI-X
> interrupts. It would make sense to have a macro which defines all types
> of message signalled interrupts, to use in such situations. Add
> PCI_IRQ_MSI_TYPES, for this purpose.
To state my objection voices in patch 3 here again:
I think this is a very bad idea. Everyone knows what MSI and MSI-X
mean and that directly maps to specification. The new IMS interrupt
scheme from the Intel SIOV spec for example is a message signalled
interrupt type as well and should not be picked up automatically.
If we want to change anything in this area we should probably remove
PCI_IRQ_ALL_TYPES instead..
next prev parent reply other threads:[~2020-06-10 7:08 UTC|newest]
Thread overview: 81+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-02 9:16 [PATCH 00/15] forward MSIx vector enable error code in pci_alloc_irq_vectors_affinity Piotr Stankiewicz
2020-06-02 9:16 ` Piotr Stankiewicz
2020-06-02 9:16 ` Piotr Stankiewicz
2020-06-02 23:06 ` Bjorn Helgaas
2020-06-02 23:06 ` Bjorn Helgaas
2020-06-03 11:42 ` [PATCH v2 00/15] Forward MSI-X vector enable error code in pci_alloc_irq_vectors_affinity() Piotr Stankiewicz
2020-06-03 11:42 ` Piotr Stankiewicz
2020-06-03 11:44 ` [PATCH v2 01/15] PCI/MSI: " Piotr Stankiewicz
2020-06-03 15:48 ` Logan Gunthorpe
2020-06-03 16:04 ` Stankiewicz, Piotr
2020-06-03 16:22 ` Logan Gunthorpe
2020-06-09 9:27 ` Stankiewicz, Piotr
2020-06-03 11:45 ` [PATCH v2 02/15] PCI: Add shorthand define for message signalled interrupt types Piotr Stankiewicz
2020-06-03 11:45 ` Piotr Stankiewicz
2020-06-03 15:49 ` Logan Gunthorpe
2020-06-03 15:49 ` Logan Gunthorpe
2020-06-04 1:55 ` Luben Tuikov
2020-06-04 1:55 ` Luben Tuikov
2020-06-03 11:46 ` [PATCH v2 03/15] PCI: Use PCI_IRQ_MSI_TYPES where appropriate Piotr Stankiewicz
2020-06-03 11:47 ` [PATCH v2 04/15] ahci: " Piotr Stankiewicz
2020-06-03 11:47 ` [PATCH v2 05/15] crypto: inside-secure - " Piotr Stankiewicz
2020-06-03 13:30 ` kernel test robot
2020-06-03 13:30 ` kernel test robot
2020-06-03 11:47 ` [PATCH v2 06/15] dmaengine: dw-edma: " Piotr Stankiewicz
2020-06-03 11:54 ` Gustavo Pimentel
2020-06-03 11:47 ` [PATCH v2 07/15] drm/amdgpu: " Piotr Stankiewicz
2020-06-03 11:47 ` Piotr Stankiewicz
2020-06-03 11:47 ` Piotr Stankiewicz
2020-06-03 13:43 ` Alex Deucher
2020-06-03 13:43 ` Alex Deucher
2020-06-03 13:43 ` Alex Deucher
2020-06-03 11:48 ` [PATCH v2 08/15] IB/qib: " Piotr Stankiewicz
2020-06-03 11:48 ` [PATCH v2 09/15] media: ddbridge: " Piotr Stankiewicz
2020-06-03 11:48 ` [PATCH v2 10/15] vmw_vmci: Use PCI_IRQ_ALL_TYPES " Piotr Stankiewicz
2020-06-03 11:49 ` [PATCH v2 11/15] mmc: sdhci: Use PCI_IRQ_MSI_TYPES " Piotr Stankiewicz
2020-06-03 11:49 ` [PATCH v2 12/15] amd-xgbe: " Piotr Stankiewicz
2020-06-03 11:49 ` [PATCH v2 13/15] aquantia: atlantic: Use PCI_IRQ_ALL_TYPES " Piotr Stankiewicz
2020-06-03 11:49 ` [PATCH v2 14/15] net: hns3: Use PCI_IRQ_MSI_TYPES " Piotr Stankiewicz
2020-06-03 11:50 ` [PATCH v2 15/15] scsi: Use PCI_IRQ_MSI_TYPES and PCI_IRQ_ALL_TYPES " Piotr Stankiewicz
2020-06-09 9:11 ` [PATCH v3 00/15] Forward MSI-X vector enable error code in pci_alloc_irq_vectors_affinity() Piotr Stankiewicz
2020-06-09 9:11 ` Piotr Stankiewicz
2020-06-09 9:11 ` Piotr Stankiewicz
2020-06-09 9:14 ` [PATCH v3 01/15] PCI/MSI: " Piotr Stankiewicz
2020-06-09 15:49 ` Logan Gunthorpe
2020-06-09 15:49 ` Christoph Hellwig
2020-06-09 9:15 ` [PATCH v3 02/15] PCI: Add macro for message signalled interrupt types Piotr Stankiewicz
2020-06-09 9:15 ` Piotr Stankiewicz
2020-06-09 9:16 ` [PATCH v3 03/15] PCI: Use PCI_IRQ_MSI_TYPES where appropriate Piotr Stankiewicz
2020-06-09 15:51 ` Christoph Hellwig
2020-06-09 16:31 ` Stankiewicz, Piotr
2020-06-09 16:35 ` Logan Gunthorpe
2020-06-09 9:17 ` [PATCH v3 04/15] ahci: " Piotr Stankiewicz
2020-06-09 9:17 ` [PATCH v3 05/15] crypto: inside-secure - " Piotr Stankiewicz
2020-06-09 9:17 ` [PATCH v3 06/15] dmaengine: dw-edma: " Piotr Stankiewicz
2020-06-09 10:01 ` Andy Shevchenko
2020-06-09 9:18 ` [PATCH v3 07/15] drm/amdgpu: " Piotr Stankiewicz
2020-06-09 9:18 ` Piotr Stankiewicz
2020-06-09 9:18 ` Piotr Stankiewicz
2020-06-09 20:23 ` Alex Deucher
2020-06-09 20:23 ` Alex Deucher
2020-06-09 20:23 ` Alex Deucher
2020-06-16 7:49 ` Stankiewicz, Piotr
2020-06-16 7:49 ` Stankiewicz, Piotr
2020-06-16 7:49 ` Stankiewicz, Piotr
2020-06-16 8:42 ` [PATCH] drm/amdgpu: Simplify IRQ vector request logic Piotr Stankiewicz
2020-06-16 8:42 ` Piotr Stankiewicz
2020-06-16 8:42 ` Piotr Stankiewicz
2020-06-09 9:18 ` [PATCH v3 08/15] IB/qib: Use PCI_IRQ_MSI_TYPES where appropriate Piotr Stankiewicz
2020-06-11 13:17 ` Ruhl, Michael J
2020-06-09 9:18 ` [PATCH v3 09/15] media: ddbridge: " Piotr Stankiewicz
2020-06-09 9:19 ` [PATCH v3 10/15] vmw_vmci: Use PCI_IRQ_ALL_TYPES " Piotr Stankiewicz
2020-06-09 9:19 ` [PATCH v3 11/15] mmc: sdhci: Use PCI_IRQ_MSI_TYPES " Piotr Stankiewicz
2020-06-09 9:19 ` [PATCH v3 12/15] amd-xgbe: " Piotr Stankiewicz
2020-06-09 9:19 ` [PATCH v3 13/15] aquantia: atlantic: Use PCI_IRQ_ALL_TYPES " Piotr Stankiewicz
2020-06-09 9:20 ` [PATCH v3 14/15] net: hns3: Use PCI_IRQ_MSI_TYPES " Piotr Stankiewicz
2020-06-09 9:20 ` [PATCH v3 15/15] scsi: Use PCI_IRQ_MSI_TYPES and PCI_IRQ_ALL_TYPES " Piotr Stankiewicz
2020-06-09 16:22 ` [PATCH v3 02/15] PCI: Add macro for message signalled interrupt types Piotr Stankiewicz
2020-06-10 7:08 ` Christoph Hellwig [this message]
2020-06-16 7:39 ` Stankiewicz, Piotr
2020-06-16 7:33 ` [PATCH v4] PCI/MSI: Forward MSI-X vector enable error code in pci_alloc_irq_vectors_affinity() Piotr Stankiewicz
2020-06-30 22:04 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200610070828.GA29678@infradead.org \
--to=hch@infradead.org \
--cc=amurray@thegoodpenguin.co.uk \
--cc=andriy.shevchenko@intel.com \
--cc=bhelgaas@google.com \
--cc=corbet@lwn.net \
--cc=efremov@linux.com \
--cc=herbert@gondor.apana.org.au \
--cc=hkallweit1@gmail.com \
--cc=kw@linux.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=piotr.stankiewicz@intel.com \
--cc=rafael.j.wysocki@intel.com \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=skunberg.kelsey@gmail.com \
--cc=yangyicong@hisilicon.com \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.