From: Rob Herring <robh@kernel.org>
To: Heiko Stuebner <heiko@sntech.de>
Cc: davem@davemloft.net, kuba@kernel.org, andrew@lunn.ch,
f.fainelli@gmail.com, hkallweit1@gmail.com,
linux@armlinux.org.uk, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
christoph.muellner@theobroma-systems.com,
Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
Subject: Re: [PATCH v2 2/2] net: phy: mscc: handle the clkout control on some phy variants
Date: Wed, 17 Jun 2020 15:45:18 -0600 [thread overview]
Message-ID: <20200617214518.GA2870745@bogus> (raw)
In-Reply-To: <20200609133140.1421109-2-heiko@sntech.de>
On Tue, Jun 09, 2020 at 03:31:40PM +0200, Heiko Stuebner wrote:
> From: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
>
> At least VSC8530/8531/8540/8541 contain a clock output that can emit
> a predefined rate of 25, 50 or 125MHz.
>
> This may then feed back into the network interface as source clock.
> So follow the example the at803x already set and introduce a
> vsc8531,clk-out-frequency property to set that output.
>
> Signed-off-by: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
> ---
> Hi Andrew,
>
> I didn't change the property yet, do you have a suggestion on
> how to name it though? Going by the other examples in the
> ethernet-phy.yamls, something like enet-phy-clock-out-frequency ?
The correct thing to do here is make the phy a clock provider and then
the client side use 'assigned-clock-rate' to set the rate. That has the
advantage that it also describes the connection of the clock signal. You
might not need that for a simple case, but I could imagine needing that
in a more complex case.
Rob
next prev parent reply other threads:[~2020-06-17 21:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-09 13:31 [PATCH v2 1/2] net: phy: mscc: move shared probe code into a helper Heiko Stuebner
2020-06-09 13:31 ` [PATCH v2 2/2] net: phy: mscc: handle the clkout control on some phy variants Heiko Stuebner
2020-06-11 0:03 ` David Miller
2020-06-11 13:29 ` Andrew Lunn
2020-06-17 21:45 ` Rob Herring [this message]
2020-06-12 1:37 ` [PATCH v2 1/2] net: phy: mscc: move shared probe code into a helper David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200617214518.GA2870745@bogus \
--to=robh@kernel.org \
--cc=andrew@lunn.ch \
--cc=christoph.muellner@theobroma-systems.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=heiko.stuebner@theobroma-systems.com \
--cc=heiko@sntech.de \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.