From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Macpaul Lin <macpaul.lin@mediatek.com>
Cc: Macpaul Lin <macpaul@gmail.com>, Bin Liu <b-liu@ti.com>,
linux-usb@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 4/6] usb: musb: mediatek: add reset FADDR to zero in reset interrupt handle
Date: Fri, 19 Jun 2020 10:51:43 +0200 [thread overview]
Message-ID: <20200619085143.GA677266@kroah.com> (raw)
In-Reply-To: <1592386317.5395.2.camel@mtkswgap22>
On Wed, Jun 17, 2020 at 05:31:57PM +0800, Macpaul Lin wrote:
> On Wed, 2020-06-17 at 10:58 +0200, Greg Kroah-Hartman wrote:
> > On Wed, Jun 17, 2020 at 04:17:07PM +0800, Macpaul Lin wrote:
> > > Bin Liu <b-liu@ti.com> 於 2020年5月25日 週一 上午10:53寫道：
> > > >
> > > > From: Macpaul Lin <macpaul.lin@mediatek.com>
> > > >
> > > > When receiving reset interrupt, FADDR need to be reset to zero in
> > > > peripheral mode. Otherwise ep0 cannot do enumeration when re-plugging USB
> > > > cable.
> > > >
> > > > Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
> > > > Acked-by: Min Guo <min.guo@mediatek.com>
> > > > Signed-off-by: Bin Liu <b-liu@ti.com>
> > > > ---
> > > > drivers/usb/musb/mediatek.c | 6 ++++++
> > > > 1 file changed, 6 insertions(+)
> > > >
> > > > diff --git a/drivers/usb/musb/mediatek.c b/drivers/usb/musb/mediatek.c
> > > > index 6196b0e8d77d..eebeadd26946 100644
> > > > --- a/drivers/usb/musb/mediatek.c
> > > > +++ b/drivers/usb/musb/mediatek.c
> > > > @@ -208,6 +208,12 @@ static irqreturn_t generic_interrupt(int irq, void *__hci)
> > > > musb->int_rx = musb_clearw(musb->mregs, MUSB_INTRRX);
> > > > musb->int_tx = musb_clearw(musb->mregs, MUSB_INTRTX);
> > > >
> > > > + if ((musb->int_usb & MUSB_INTR_RESET) && !is_host_active(musb)) {
> > > > + /* ep0 FADDR must be 0 when (re)entering peripheral mode */
> > > > + musb_ep_select(musb->mregs, 0);
> > > > + musb_writeb(musb->mregs, MUSB_FADDR, 0);
> > > > + }
> > > > +
> > > > if (musb->int_usb || musb->int_tx || musb->int_rx)
> > > > retval = musb_interrupt(musb);
> > > >
> > > > --
> > > > 2.17.1
> > > >
> > > Could this bug fix also been applied to stable kernel?
> >
> > Sure, what is the git commit of it in Linus's tree?
> >
> > thanks,
> >
> > greg k-h
>
> The commit id of this patch should be
> 402bcac4b25b520c89ba60db85eb6316f36e797f
Now queued up, thanks.
greg k-h
next prev parent reply other threads:[~2020-06-19 8:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-25 2:50 [PATCH 0/6] musb patches for v5.8-rc1 Bin Liu
2020-05-25 2:50 ` [PATCH 1/6] usb: musb: return -ESHUTDOWN in urb when three-strikes error happened Bin Liu
2020-05-25 2:50 ` [PATCH 2/6] usb: musb: start session in resume for host port Bin Liu
2020-05-25 2:50 ` [PATCH 3/6] usb: musb: use true for 'use_dma' Bin Liu
2020-05-25 2:50 ` [PATCH 4/6] usb: musb: mediatek: add reset FADDR to zero in reset interrupt handle Bin Liu
2020-06-17 8:17 ` Macpaul Lin
2020-06-17 8:58 ` Greg Kroah-Hartman
2020-06-17 9:31 ` Macpaul Lin
2020-06-19 8:51 ` Greg Kroah-Hartman [this message]
2020-05-25 2:50 ` [PATCH 5/6] usb: musb: jz4740: Prevent lockup when CONFIG_SMP is set Bin Liu
2020-05-25 2:50 ` [PATCH 6/6] usb: musb: Fix runtime PM imbalance on error Bin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200619085143.GA677266@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=b-liu@ti.com \
--cc=linux-usb@vger.kernel.org \
--cc=macpaul.lin@mediatek.com \
--cc=macpaul@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.