[PATCH v4 4/4] spi: spi-fsl-dspi: Initialize completion before possible interrupt

From: Krzysztof Kozlowski <krzk@kernel.org>
To: Mark Brown <broonie@kernel.org>, Peng Ma <peng.ma@nxp.com>,
	linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Vladimir Oltean <vladimir.oltean@nxp.com>,
	Wolfram Sang <wsa@kernel.org>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Krzysztof Kozlowski <krzk@kernel.org>
Subject: [PATCH v4 4/4] spi: spi-fsl-dspi: Initialize completion before possible interrupt
Date: Mon, 22 Jun 2020 13:05:43 +0200	[thread overview]
Message-ID: <20200622110543.5035-4-krzk@kernel.org> (raw)
In-Reply-To: <20200622110543.5035-1-krzk@kernel.org>

The interrupt handler calls completion and is IRQ requested before the
completion is initialized.  Logically it should be the other way.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

---

Changes since v2:
1. None

Changes since v1:
1. Rework the commit msg.
---
 drivers/spi/spi-fsl-dspi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/spi/spi-fsl-dspi.c b/drivers/spi/spi-fsl-dspi.c
index e0b30e4b1b69..91c6affe139c 100644
--- a/drivers/spi/spi-fsl-dspi.c
+++ b/drivers/spi/spi-fsl-dspi.c
@@ -1389,6 +1389,8 @@ static int dspi_probe(struct platform_device *pdev)
 		goto poll_mode;
 	}
 
+	init_completion(&dspi->xfer_done);
+
 	ret = request_threaded_irq(dspi->irq, dspi_interrupt, NULL,
 				   IRQF_SHARED, pdev->name, dspi);
 	if (ret < 0) {
@@ -1396,8 +1398,6 @@ static int dspi_probe(struct platform_device *pdev)
 		goto out_clk_put;
 	}
 
-	init_completion(&dspi->xfer_done);
-
 poll_mode:
 
 	if (dspi->devtype_data->trans_mode == DSPI_DMA_MODE) {
-- 
2.17.1

