Re: [PATCH 13/19] ASoC: codecs: wm*: merge .digital_mute() into .mute_stream()

From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: "Shengjiu Wang" <shengjiu.wang@nxp.com>,
	Linux-ALSA <alsa-devel@alsa-project.org>,
	"Michael Walle" <michael@walle.cc>,
	"\"Heiko Stübner\"" <heiko@sntech.de>,
	"Neil Armstrong" <narmstrong@baylibre.com>,
	"David Airlie" <airlied@linux.ie>,
	"\"Michał Mirosław\"" <mirq-linux@rere.qmqm.pl>,
	"Jonghwan Choi" <charlie.jh@kakaocorp.com>,
	"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
	"Paul Cercueil" <paul@crapouillou.net>,
	"Andrzej Hajda" <a.hajda@samsung.com>,
	"Frank Shi" <shifu0704@thundersoft.com>,
	"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
	"Benjamin Gaignard" <benjamin.gaignard@linaro.org>,
	"Andrew F. Davis" <afd@ti.com>,
	"Fabio Estevam" <festevam@gmail.com>,
	"Jerome Brunet" <jbrunet@baylibre.com>,
	"Nikita Yushchenko" <nikita.yoush@cogentembedded.com>,
	"Pierre-Louis Bossart" <pierre-louis.bossart@linux.intel.com>,
	"Lars-Peter Clausen" <lars@metafoo.de>,
	"Joonyoung Shim" <jy0922.shim@samsung.com>,
	"Matthias Reichl" <hias@horus.com>,
	"Katsuhiro Suzuki" <katsuhiro@katsuster.net>,
	"Kevin Hilman" <khilman@baylibre.com>,
	"Kai Vehmanen" <kai.vehmanen@linux.intel.com>,
	"Takashi Iwai" <tiwai@suse.com>,
	YueHaibing <yuehaibing@huawei.com>,
	"Russell King" <linux@armlinux.org.uk>,
	"Krzysztof Kozlowski" <krzk@kernel.org>,
	"Daniel Drake" <drake@endlessm.com>,
	"Tzung-Bi Shih" <tzungbi@google.com>,
	"Ludovic Desroches" <ludovic.desroches@microchip.com>,
	"Kukjin Kim" <kgene@kernel.org>,
	"Ranjani Sridharan" <ranjani.sridharan@linux.intel.com>,
	"Dinghao Liu" <dinghao.liu@zju.edu.cn>,
	"Codrin Ciubotariu" <codrin.ciubotariu@microchip.com>,
	"Cheng-Yi Chiang" <cychiang@chromium.org>,
	"Chun-Kuang Hu" <chunkuang.hu@kernel.org>,
	"Bartosz Golaszewski" <bgolaszewski@baylibre.com>,
	"Philipp Zabel" <p.zabel@pengutronix.de>,
	"Jonas Karlman" <jonas@kwiboo.se>,
	"Liam Girdwood" <lgirdwood@gmail.com>,
	"Nicolas Ferre" <nicolas.ferre@microchip.com>,
	"Chuhong Yuan" <hslester96@gmail.com>,
	"Robin Murphy" <robin.murphy@arm.com>,
	"James Schulman" <james.schulman@cirrus.com>,
	"Inki Dae" <inki.dae@samsung.com>,
	"Masahiro Yamada" <masahiroy@kernel.org>,
	"Mark Brown" <broonie@kernel.org>,
	"Christophe JAILLET" <christophe.jaillet@wanadoo.fr>,
	"Dan Murphy" <dmurphy@ti.com>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"\"Nuno Sá\"" <nuno.sa@analog.com>,
	"Vincent Abriou" <vincent.abriou@st.com>,
	"Peter Ujfalusi" <peter.ujfalusi@ti.com>,
	"Jernej Skrabec" <jernej.skrabec@siol.net>,
	"Support Opensource" <support.opensource@diasemi.com>,
	"Marek Szyprowski" <m.szyprowski@samsung.com>,
	"Jason Yan" <yanaijie@huawei.com>,
	"Stephen Boyd" <sboyd@kernel.org>,
	"Pankaj Bharadiya" <pankaj.laxminarayan.bharadiya@intel.com>,
	"David Rhodes" <david.rhodes@cirrus.com>,
	"Seung-Woo Kim" <sw0312.kim@samsung.com>,
	"Sandy Huang" <hjc@rock-chips.com>, "Pavel Dobias" <dobias@2n.cz>,
	"Philipp Puschmann" <p.puschmann@pironex.de>,
	"Kyungmin Park" <kyungmin.park@samsung.com>,
	"Vishwas A Deshpande" <vishwas.a.deshpande@ti.com>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Colin Ian King" <colin.king@canonical.com>,
	"Kevin Cernekee" <cernekee@chromium.org>,
	"Lucas Stach" <l.stach@pengutronix.de>,
	"Shawn Guo" <shawnguo@kernel.org>,
	"Peter Rosin" <peda@axentia.se>,
	"M R Swami Reddy" <mr.swami.reddy@ti.com>
Subject: Re: [PATCH 13/19] ASoC: codecs: wm*: merge .digital_mute() into .mute_stream()
Date: Tue, 23 Jun 2020 10:29:06 +0000	[thread overview]
Message-ID: <20200623102906.GX71940@ediswmail.ad.cirrus.com> (raw)
In-Reply-To: <87wo3y1ssz.wl-kuninori.morimoto.gx@renesas.com>

On Tue, Jun 23, 2020 at 10:20:43AM +0900, Kuninori Morimoto wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> 
> snd_soc_dai_digital_mute() is internally using both
> mute_stream() (1) or digital_mute() (2), but the difference between
> these 2 are only handling direction.
> We can merge digital_mute() into mute_stream
> 
> 	int snd_soc_dai_digital_mute(xxx, int direction)
> 	{
> 		...
> 		else if (dai->driver->ops->mute_stream)
> (1)			return dai->driver->ops->mute_stream(xxx, direction);
> 		else if (direction == SNDRV_PCM_STREAM_PLAYBACK &&
> 			 dai->driver->ops->digital_mute)
> (2)			return dai->driver->ops->digital_mute(xxx);
> 		...
> 	}
> 
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---

Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>

Thanks,
Charles