All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Phu Luu <Phu.Luu@silabs.com>
Cc: "johan@kernel.org" <johan@kernel.org>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Brant Merryman <Brant.Merryman@silabs.com>,
	Richard Hendricks <Richard.Hendricks@silabs.com>
Subject: Re: [PATCH v3 1/2] USB: serial: cp210x: Enable usb generic throttle/unthrottle
Date: Wed, 24 Jun 2020 09:43:02 +0200	[thread overview]
Message-ID: <20200624074302.GK3334@localhost> (raw)
In-Reply-To: <DM6PR11MB28578CA6D09D13A07D7959D99C950@DM6PR11MB2857.namprd11.prod.outlook.com>

On Wed, Jun 24, 2020 at 07:01:33AM +0000, Phu Luu wrote:
> Assign the .throttle and .unthrottle functions to be generic function
> in the driver structure to prevent data loss that can otherwise occur
> if the host does not enable USB throttling.
> 
> Signed-off-by: Phu Luu <phu.luu@silabs.com>
> Signed-off-by: Brant Merryman <brant.merryman@silabs.com>

One last form issue (besides the whitespace corrupted patch 2/2 that
Greg pointed out): The SOB tags records how a patch got into the
kernel (e.g. who forwarded it) and the first SOB should generally be the
author's.

In this case, I guess Brant is the primary author as he submitted these
patches last time around. If so, you need to manually add From line at
the beginning of the mail (i.e. before the commit message). If you use
git-format-patch, git would handle that for you.

You can also use the newish "Co-developed-by" tag to indicate joint
authorship. More details can be found in 

	Documentation/process/submitting-patches.rst

Johan

  reply	other threads:[~2020-06-24  7:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-24  7:01 [PATCH v3 1/2] USB: serial: cp210x: Enable usb generic throttle/unthrottle Phu Luu
2020-06-24  7:43 ` Johan Hovold [this message]
2020-06-26  4:22 Phu Luu
2020-06-26  7:36 ` Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200624074302.GK3334@localhost \
    --to=johan@kernel.org \
    --cc=Brant.Merryman@silabs.com \
    --cc=Phu.Luu@silabs.com \
    --cc=Richard.Hendricks@silabs.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.