Re: [Intel-gfx] [PATCH 25/26] drm/i915: Ensure we hold the pin mutex

From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [Intel-gfx] [PATCH 25/26] drm/i915: Ensure we hold the pin mutex
Date: Wed, 24 Jun 2020 09:52:23 +0800	[thread overview]
Message-ID: <202006240958.cQFqoHhL%lkp@intel.com> (raw)
In-Reply-To: <20200623142843.423594-25-maarten.lankhorst@linux.intel.com>

[-- Attachment #1: Type: text/plain, Size: 2874 bytes --]

Hi Maarten,

I love your patch! Yet something to improve:

[auto build test ERROR on 24b806b0a1dd38c734e771ece9dd1ab6492bbb96]

url:    https://github.com/0day-ci/linux/commits/Maarten-Lankhorst/Revert-drm-i915-gem-Async-GPU-relocations-only/20200623-223216
base:    24b806b0a1dd38c734e771ece9dd1ab6492bbb96
config: i386-debian-10.3 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce (this is a W=1 build):
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from arch/x86/include/asm/bug.h:86,
                    from include/linux/bug.h:5,
                    from arch/x86/include/asm/paravirt.h:15,
                    from arch/x86/include/asm/irqflags.h:72,
                    from include/linux/irqflags.h:16,
                    from include/linux/rcupdate.h:26,
                    from include/linux/rculist.h:11,
                    from include/linux/pid.h:5,
                    from include/linux/sched.h:14,
                    from include/linux/sched/mm.h:7,
                    from drivers/gpu/drm/i915/i915_vma.c:25:
   drivers/gpu/drm/i915/i915_vma.c: In function 'i915_ggtt_pin':
>> include/linux/dma-resv.h:80:28: error: implicit declaration of function 'lockdep_is_held'; did you mean 'lockdep_assert_held'? [-Werror=implicit-function-declaration]
      80 | #define dma_resv_held(obj) lockdep_is_held(&(obj)->lock.base)
         |                            ^~~~~~~~~~~~~~~
   include/asm-generic/bug.h:127:25: note: in definition of macro 'WARN'
     127 |  int __ret_warn_on = !!(condition);    \
         |                         ^~~~~~~~~
   drivers/gpu/drm/i915/i915_vma.c:1011:2: note: in expansion of macro 'WARN_ON'
    1011 |  WARN_ON(!ww && vma->resv && dma_resv_held(vma->resv));
         |  ^~~~~~~
   drivers/gpu/drm/i915/i915_vma.c:1011:30: note: in expansion of macro 'dma_resv_held'
    1011 |  WARN_ON(!ww && vma->resv && dma_resv_held(vma->resv));
         |                              ^~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +80 include/linux/dma-resv.h

786d7257e537da0 include/linux/reservation.h Maarten Lankhorst 2013-06-27  79  
52791eeec1d9f4a include/linux/dma-resv.h    Christian König   2019-08-11 @80  #define dma_resv_held(obj) lockdep_is_held(&(obj)->lock.base)
52791eeec1d9f4a include/linux/dma-resv.h    Christian König   2019-08-11  81  #define dma_resv_assert_held(obj) lockdep_assert_held(&(obj)->lock.base)
04a5faa8cbe5a8e include/linux/reservation.h Maarten Lankhorst 2014-07-01  82  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 34819 bytes --]