Re: [PATCH v12 7/9] tpm: tpm_tis: verify TPM_STS register is valid after locality request

From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v12 7/9] tpm: tpm_tis: verify TPM_STS register is valid after locality request
Date: Fri, 26 Jun 2020 02:59:59 +0800	[thread overview]
Message-ID: <202006260214.8iXZgxxY%lkp@intel.com> (raw)
In-Reply-To: <20200625144650.269719-8-amirmizi6@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 3465 bytes --]

Hi,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on jss-tpmdd/next]
[also build test ERROR on robh/for-next soc/for-next linus/master v5.8-rc2 next-20200625]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use  as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/amirmizi6-gmail-com/Add-tpm-i2c-ptp-driver/20200625-225437
base:   git://git.infradead.org/users/jjs/linux-tpmdd next
config: x86_64-allyesconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 8911a35180c6777188fefe0954a2451a2b91deaf)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/char/tpm/tpm_tis_core.c:225:9: error: implicit declaration of function 'wait_for_tpm_stat' [-Werror,-Wimplicit-function-declaration]
                                   if (wait_for_tpm_stat(chip, TPM_STS_GO, 0,
                                       ^
   drivers/char/tpm/tpm_tis_core.c:225:9: note: did you mean 'wait_for_tpm_stat_cond'?
   drivers/char/tpm/tpm_tis_core.c:32:13: note: 'wait_for_tpm_stat_cond' declared here
   static bool wait_for_tpm_stat_cond(struct tpm_chip *chip, u8 mask,
               ^
   1 error generated.

vim +/wait_for_tpm_stat +225 drivers/char/tpm/tpm_tis_core.c

   190	
   191	static int request_locality(struct tpm_chip *chip, int l)
   192	{
   193		struct tpm_tis_data *priv = dev_get_drvdata(&chip->dev);
   194		unsigned long stop, timeout;
   195		long rc;
   196	
   197		if (check_locality(chip, l))
   198			return l;
   199	
   200		rc = tpm_tis_write8(priv, TPM_ACCESS(l), TPM_ACCESS_REQUEST_USE);
   201		if (rc < 0)
   202			return rc;
   203	
   204		stop = jiffies + chip->timeout_a;
   205	
   206		if (chip->flags & TPM_CHIP_FLAG_IRQ) {
   207	again:
   208			timeout = stop - jiffies;
   209			if ((long)timeout <= 0)
   210				return -1;
   211			rc = wait_event_interruptible_timeout(priv->int_queue,
   212							      (check_locality
   213							       (chip, l)),
   214							      timeout);
   215			if (rc > 0)
   216				return l;
   217			if (rc == -ERESTARTSYS && freezing(current)) {
   218				clear_thread_flag(TIF_SIGPENDING);
   219				goto again;
   220			}
   221		} else {
   222			/* wait for burstcount */
   223			do {
   224				if (check_locality(chip, l)) {
 > 225					if (wait_for_tpm_stat(chip, TPM_STS_GO, 0,
   226							      chip->timeout_c,
   227							      &priv->int_queue,
   228							      false) < 0)
   229						return -ETIME;
   230					return l;
   231				}
   232				tpm_msleep(TPM_TIMEOUT);
   233			} while (time_before(jiffies, stop));
   234		}
   235		return -1;
   236	}
   237	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 75314 bytes --]