From: "Michael S. Tsirkin" <mst@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: cohuck@redhat.com, jasowang@redhat.com, qemu-devel@nongnu.org,
hanand@xilinx.com, rob.miller@broadcom.com, saugatm@xilinx.com,
Cindy Lu <lulu@redhat.com>,
armbru@redhat.com, hch@infradead.org, eperezma@redhat.com,
jgg@mellanox.com, mhabets@solarflare.com, shahafs@mellanox.com,
kevin.tian@intel.com, parav@mellanox.com, vmireyno@marvell.com,
cunming.liang@intel.com, gdawar@xilinx.com, jiri@mellanox.com,
xiao.w.wang@intel.com, stefanha@redhat.com,
zhihong.wang@intel.com, Tiwei Bie <tiwei.bie@intel.com>,
aadam@redhat.com, rdunlap@infradead.org,
maxime.coquelin@redhat.com, lingshan.zhu@intel.com
Subject: Re: [PATCH v3 13/13] vhost-vdpa: introduce vhost-vdpa net client
Date: Wed, 1 Jul 2020 11:20:50 -0400 [thread overview]
Message-ID: <20200701112022-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <dc1c8668-54b7-4b9f-cf0f-a0479339fa7d@redhat.com>
On Wed, Jul 01, 2020 at 09:28:27AM -0500, Eric Blake wrote:
> On 7/1/20 4:24 AM, Cindy Lu wrote:
> > This patch set introduces a new net client type: vhost-vdpa.
> > vhost-vdpa net client will set up a vDPA device which is specified
> > by a "vhostdev" parameter.
> >
> > Signed-off-by: Lingshan Zhu <lingshan.zhu@intel.com>
> > Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
> > Signed-off-by: Cindy Lu <lulu@redhat.com>
> > Signed-off-by: Jason Wang <jasowang@redhat.com>
> > ---
>
> > +++ b/qapi/net.json
>
> > ##
> > # @NetClientDriver:
> > #
> > # Available netdev drivers.
> > #
> > -# Since: 2.7
> > +# Since: 5.1
>
> This should be:
>
> # Since 2.7
> # @vhost-vdpa since 5.1
>
> since the enum itself is still available in older releases, it is only the
> new member that was introduced in this series.
>
> > ##
> > { 'enum': 'NetClientDriver',
> > 'data': [ 'none', 'nic', 'user', 'tap', 'l2tpv3', 'socket', 'vde',
> > - 'bridge', 'hubport', 'netmap', 'vhost-user' ] }
> > + 'bridge', 'hubport', 'netmap', 'vhost-user', 'vhost-vdpa' ] }
>
Thanks! I will fix it up when applying.
Ack with that fixed?
> --
> Eric Blake, Principal Software Engineer
> Red Hat, Inc. +1-919-301-3226
> Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2020-07-01 15:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 9:24 [PATCH v3 00/13] vDPA support in qemu Cindy Lu
2020-07-01 9:24 ` [PATCH v3 01/13] net: introduce qemu_get_peer Cindy Lu
2020-07-01 9:24 ` [PATCH v3 02/13] vhost_net: use the function qemu_get_peer Cindy Lu
2020-07-01 9:24 ` [PATCH v3 03/13] virtio-bus: introduce queue_enabled method Cindy Lu
2020-07-01 9:24 ` [PATCH v3 04/13] virtio-pci: implement " Cindy Lu
2020-07-01 9:24 ` [PATCH v3 05/13] vhost: check the existence of vhost_set_iotlb_callback Cindy Lu
2020-07-01 9:24 ` [PATCH v3 06/13] vhost: introduce new VhostOps vhost_dev_start Cindy Lu
2020-07-01 9:24 ` [PATCH v3 07/13] vhost: implement vhost_dev_start method Cindy Lu
2020-07-01 9:24 ` [PATCH v3 08/13] vhost: introduce new VhostOps vhost_vq_get_addr Cindy Lu
2020-07-01 9:24 ` [PATCH v3 09/13] vhost: implement vhost_vq_get_addr method Cindy Lu
2020-07-01 9:24 ` [PATCH v3 10/13] vhost: introduce new VhostOps vhost_force_iommu Cindy Lu
2020-07-01 9:24 ` [PATCH v3 11/13] vhost: implement vhost_force_iommu method Cindy Lu
2020-07-01 9:24 ` [PATCH v3 12/13] vhost-vdpa: introduce vhost-vdpa backend Cindy Lu
2020-07-01 9:24 ` [PATCH v3 13/13] vhost-vdpa: introduce vhost-vdpa net client Cindy Lu
2020-07-01 14:28 ` Eric Blake
2020-07-01 15:20 ` Michael S. Tsirkin [this message]
2020-07-02 2:39 ` Cindy Lu
2020-07-01 9:53 ` [PATCH v3 00/13] vDPA support in qemu no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200701112022-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=aadam@redhat.com \
--cc=armbru@redhat.com \
--cc=cohuck@redhat.com \
--cc=cunming.liang@intel.com \
--cc=eblake@redhat.com \
--cc=eperezma@redhat.com \
--cc=gdawar@xilinx.com \
--cc=hanand@xilinx.com \
--cc=hch@infradead.org \
--cc=jasowang@redhat.com \
--cc=jgg@mellanox.com \
--cc=jiri@mellanox.com \
--cc=kevin.tian@intel.com \
--cc=lingshan.zhu@intel.com \
--cc=lulu@redhat.com \
--cc=maxime.coquelin@redhat.com \
--cc=mhabets@solarflare.com \
--cc=parav@mellanox.com \
--cc=qemu-devel@nongnu.org \
--cc=rdunlap@infradead.org \
--cc=rob.miller@broadcom.com \
--cc=saugatm@xilinx.com \
--cc=shahafs@mellanox.com \
--cc=stefanha@redhat.com \
--cc=tiwei.bie@intel.com \
--cc=vmireyno@marvell.com \
--cc=xiao.w.wang@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.