From: Rikard Falkeborn <rikard.falkeborn@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Arnd Bergmann <arnd@arndb.de>
Cc: Rikard Falkeborn <rikard.falkeborn@gmail.com>,
Corey Minyard <minyard@acm.org>,
openipmi-developer@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: [PATCH 4/5] ipmi: watchdog: Constify ident
Date: Wed, 1 Jul 2020 22:09:49 +0200 [thread overview]
Message-ID: <20200701200950.30314-5-rikard.falkeborn@gmail.com> (raw)
In-Reply-To: <20200701200950.30314-1-rikard.falkeborn@gmail.com>
ident is not modified and can be made const to allow the compiler to put
it in read-only memory.
Before:
text data bss dec hex filename
14067 3188 64 17319 43a7 drivers/char/ipmi/ipmi_watchdog.o
After:
text data bss dec hex filename
14115 3148 64 17327 43af drivers/char/ipmi/ipmi_watchdog.o
Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
---
drivers/char/ipmi/ipmi_watchdog.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/ipmi/ipmi_watchdog.c b/drivers/char/ipmi/ipmi_watchdog.c
index 55986e10a124..3df13c3da5f9 100644
--- a/drivers/char/ipmi/ipmi_watchdog.c
+++ b/drivers/char/ipmi/ipmi_watchdog.c
@@ -654,7 +654,7 @@ static int ipmi_heartbeat(void)
return rv;
}
-static struct watchdog_info ident = {
+static const struct watchdog_info ident = {
.options = 0, /* WDIOF_SETTIMEOUT, */
.firmware_version = 1,
.identity = "IPMI"
--
2.27.0
next prev parent reply other threads:[~2020-07-01 21:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 20:09 [PATCH 0/5] drivers/char: Constify static variables Rikard Falkeborn
2020-07-01 20:09 ` Rikard Falkeborn
2020-07-01 20:09 ` [PATCH 1/5] hwrng: bcm2835 - Constify bcm2835_rng_devtype[] Rikard Falkeborn
2020-07-01 20:09 ` Rikard Falkeborn
2020-07-01 21:52 ` Florian Fainelli
2020-07-01 21:52 ` Florian Fainelli
2020-07-01 20:09 ` [PATCH 2/5] hwrng: nomadik - Constify nmk_rng_ids[] Rikard Falkeborn
2020-07-02 7:51 ` Arnd Bergmann
2020-07-01 20:09 ` [PATCH 3/5] hwrng: virtio - Constify id_table[] Rikard Falkeborn
2020-07-01 20:09 ` Rikard Falkeborn [this message]
2020-07-01 20:09 ` [PATCH 5/5] virtio_console: Constify some static variables Rikard Falkeborn
2020-07-05 18:30 ` Amit Shah
2020-07-05 20:50 ` Joe Perches
2020-07-02 8:58 ` [PATCH 0/5] drivers/char: Constify " Arnd Bergmann
2020-07-02 8:58 ` Arnd Bergmann
2020-07-02 8:58 ` Arnd Bergmann
2020-07-09 12:54 ` Herbert Xu
2020-07-09 12:54 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200701200950.30314-5-rikard.falkeborn@gmail.com \
--to=rikard.falkeborn@gmail.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minyard@acm.org \
--cc=openipmi-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.