Re: [PATCH 09/23] iio:adc:ltc2497 drop of_match_ptr protection

From: Jonathan Cameron <jic23@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-iio@vger.kernel.org, alexandru.Ardelean@analog.com,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	Michael Hennerich <michael.hennerich@analog.com>
Subject: Re: [PATCH 09/23] iio:adc:ltc2497 drop of_match_ptr protection
Date: Sat, 4 Jul 2020 18:04:30 +0100	[thread overview]
Message-ID: <20200704180430.0a6d5df1@archlinux> (raw)
In-Reply-To: <20200628155324.y257v4tf5xvzb5xh@pengutronix.de>

On Sun, 28 Jun 2020 17:53:24 +0200
Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:

> On Sun, Jun 28, 2020 at 01:36:40PM +0100, Jonathan Cameron wrote:
> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > 
> > This prevents the driver being used with ACPI PRP0001 based
> > bindings. Also switch include to mod_devicetable.h which devices
> > the used id structure.
> > 
> > Note this is most about removing something I don't want want cut
> > and paste into new driver rather than any thought that this particular
> > driver will be used in an ACPI system (though it might!)
> > 
> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > Cc: Michael Hennerich <michael.hennerich@analog.com>
> > Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > ---
> >  drivers/iio/adc/ltc2497.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/iio/adc/ltc2497.c b/drivers/iio/adc/ltc2497.c
> > index 5db63d7c6bc5..1adddf5a88a9 100644
> > --- a/drivers/iio/adc/ltc2497.c
> > +++ b/drivers/iio/adc/ltc2497.c
> > @@ -11,7 +11,7 @@
> >  #include <linux/iio/iio.h>
> >  #include <linux/iio/driver.h>
> >  #include <linux/module.h>
> > -#include <linux/of.h>
> > +#include <linux/mod_devicetable.h>
> >  
> >  #include "ltc2497.h"
> >  
> > @@ -98,7 +98,7 @@ MODULE_DEVICE_TABLE(of, ltc2497_of_match);
> >  static struct i2c_driver ltc2497_driver = {
> >  	.driver = {
> >  		.name = "ltc2497",
> > -		.of_match_table = of_match_ptr(ltc2497_of_match),
> > +		.of_match_table = ltc2497_of_match,  
> 
> This was the copy source of ltc2496_driver. there the change was fine,
> so it is here:
> 
> Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Applied thanks,

J

> 
> Best regards
> Uwe
>