Re: [PATCH V8 2/8] soc: qcom-geni-se: Add interconnect support to fix earlycon crash

From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH V8 2/8] soc: qcom-geni-se: Add interconnect support to fix earlycon crash
Date: Mon, 06 Jul 2020 10:47:27 +0800	[thread overview]
Message-ID: <202007061029.2L6rs2Y0%lkp@intel.com> (raw)
In-Reply-To: <1592908737-7068-3-git-send-email-akashast@codeaurora.org>

[-- Attachment #1: Type: text/plain, Size: 3015 bytes --]

Hi Akash,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on spi/for-next]
[also build test ERROR on wsa/i2c/for-next driver-core/driver-core-testing usb/usb-testing linus/master v5.8-rc4]
[cannot apply to tty/tty-testing next-20200703]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use  as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Akash-Asthana/Add-interconnect-support-to-QSPI-and-QUP-drivers/20200623-184128
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
config: ia64-randconfig-s031-20200705 (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.2-14-g8fce3d7a-dirty
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=ia64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/soc/qcom/qcom-geni-se.c: In function 'geni_remove_earlycon_icc_vote':
>> drivers/soc/qcom/qcom-geni-se.c:819:11: error: implicit declaration of function 'of_get_next_parent'; did you mean 'of_get_parent'? [-Werror=implicit-function-declaration]
     819 |  parent = of_get_next_parent(wrapper->dev->of_node);
         |           ^~~~~~~~~~~~~~~~~~
         |           of_get_parent
   drivers/soc/qcom/qcom-geni-se.c:819:9: warning: assignment to 'struct device_node *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
     819 |  parent = of_get_next_parent(wrapper->dev->of_node);
         |         ^
   cc1: some warnings being treated as errors

vim +819 drivers/soc/qcom/qcom-geni-se.c

   808	
   809	void geni_remove_earlycon_icc_vote(void)
   810	{
   811		struct geni_wrapper *wrapper;
   812		struct device_node *parent;
   813		struct device_node *child;
   814	
   815		if (!earlycon_wrapper)
   816			return;
   817	
   818		wrapper = earlycon_wrapper;
 > 819		parent = of_get_next_parent(wrapper->dev->of_node);
   820		for_each_child_of_node(parent, child) {
   821			if (!of_device_is_compatible(child, "qcom,geni-se-qup"))
   822				continue;
   823			wrapper = platform_get_drvdata(of_find_device_by_node(child));
   824			icc_put(wrapper->to_core.path);
   825			wrapper->to_core.path = NULL;
   826	
   827		}
   828		of_node_put(parent);
   829	
   830		earlycon_wrapper = NULL;
   831	}
   832	EXPORT_SYMBOL(geni_remove_earlycon_icc_vote);
   833	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 31280 bytes --]