From: Joonsoo Kim <js1304@gmail.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
kernel-team@lge.com, Vlastimil Babka <vbabka@suse.cz>,
Christoph Hellwig <hch@infradead.org>,
Roman Gushchin <guro@fb.com>,
Mike Kravetz <mike.kravetz@oracle.com>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Subject: Re: [PATCH v4 07/11] mm/gup: use a standard migration target allocation callback
Date: Wed, 8 Jul 2020 16:21:33 +0900 [thread overview]
Message-ID: <20200708072132.GE16543@js1304-desktop> (raw)
In-Reply-To: <20200707114614.GK5913@dhcp22.suse.cz>
On Tue, Jul 07, 2020 at 01:46:14PM +0200, Michal Hocko wrote:
> On Tue 07-07-20 16:44:45, Joonsoo Kim wrote:
> [...]
> > @@ -1551,9 +1552,12 @@ struct page *alloc_migration_target(struct page *page, unsigned long private)
> >
> > gfp_mask |= htlb_alloc_mask(h);
> > return alloc_huge_page_nodemask(h, nid, mtc->nmask,
> > - gfp_mask, false);
> > + gfp_mask, mtc->skip_cma);
> > }
> >
> > + if (mtc->skip_cma)
> > + flags = memalloc_nocma_save();
> > +
>
> As already mentioned in previous email this is a completely wrong usage
> of the scope API. The scope should be defined by the caller and this
> should be all transparent by the allocator layer.
Okay. Like as newly sent patch for 04/11, this patch will also be changed.
Thanks.
next prev parent reply other threads:[~2020-07-08 7:21 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 7:44 [PATCH v4 00/11] clean-up the migration target allocation functions js1304
2020-07-07 7:44 ` [PATCH v4 01/11] mm/page_isolation: prefer the node of the source page js1304
2020-07-07 7:44 ` [PATCH v4 02/11] mm/migrate: move migration helper from .h to .c js1304
2020-07-07 7:44 ` [PATCH v4 03/11] mm/hugetlb: unify migration callbacks js1304
2020-07-07 11:05 ` Vlastimil Babka
2020-07-07 11:19 ` Michal Hocko
2020-07-07 7:44 ` [PATCH v4 04/11] mm/hugetlb: make hugetlb migration callback CMA aware js1304
2020-07-07 11:22 ` Vlastimil Babka
2020-07-08 7:16 ` Joonsoo Kim
2020-07-08 7:41 ` Michal Hocko
2020-07-08 9:26 ` Vlastimil Babka
2020-07-08 10:57 ` Aneesh Kumar K.V
2020-07-08 11:32 ` Michal Hocko
2020-07-09 6:43 ` Michal Hocko
2020-07-09 7:03 ` Joonsoo Kim
2020-07-09 7:03 ` Joonsoo Kim
2020-07-09 0:27 ` Mike Kravetz
2020-07-07 11:31 ` Michal Hocko
2020-07-08 6:48 ` Michal Hocko
2020-07-08 7:12 ` Joonsoo Kim
2020-07-07 7:44 ` [PATCH v4 05/11] mm/migrate: clear __GFP_RECLAIM for THP allocation for migration js1304
2020-07-07 11:40 ` Michal Hocko
2020-07-08 7:19 ` Joonsoo Kim
2020-07-08 7:48 ` Michal Hocko
2020-07-09 3:26 ` Joonsoo Kim
2020-07-09 3:26 ` Joonsoo Kim
2020-07-07 12:17 ` Vlastimil Babka
2020-07-08 7:17 ` Joonsoo Kim
2020-07-09 7:17 ` Joonsoo Kim
2020-07-09 7:17 ` Joonsoo Kim
2020-07-07 7:44 ` [PATCH v4 06/11] mm/migrate: make a standard migration target allocation function js1304
2020-07-07 11:43 ` Michal Hocko
2020-07-07 14:49 ` Vlastimil Babka
2020-07-07 19:00 ` Michal Hocko
2020-07-09 7:15 ` Joonsoo Kim
2020-07-09 7:15 ` Joonsoo Kim
2020-07-09 10:28 ` Michal Hocko
2020-07-07 7:44 ` [PATCH v4 07/11] mm/gup: use a standard migration target allocation callback js1304
2020-07-07 11:46 ` Michal Hocko
2020-07-08 7:21 ` Joonsoo Kim [this message]
2020-07-07 7:44 ` [PATCH v4 08/11] mm/mempolicy: " js1304
2020-07-07 7:44 ` [PATCH v4 09/11] mm/page_alloc: remove a wrapper for alloc_migration_target() js1304
2020-07-07 7:44 ` [PATCH v4 10/11] mm/memory-failure: " js1304
2020-07-07 11:48 ` Michal Hocko
2020-07-07 15:03 ` Vlastimil Babka
2020-07-07 18:55 ` Michal Hocko
2020-07-07 15:00 ` Vlastimil Babka
2020-07-07 7:44 ` [PATCH v4 11/11] mm/memory_hotplug: " js1304
2020-07-07 11:52 ` Michal Hocko
2020-07-07 15:09 ` Vlastimil Babka
2020-07-09 3:25 ` Joonsoo Kim
2020-07-09 3:25 ` Joonsoo Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200708072132.GE16543@js1304-desktop \
--to=js1304@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=guro@fb.com \
--cc=hch@infradead.org \
--cc=kernel-team@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mike.kravetz@oracle.com \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.