Re: [PATCH] x86/mtrr: Drop workaround for old 32bit CPUs

From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>,
	Jan Beulich <JBeulich@suse.com>
Subject: Re: [PATCH] x86/mtrr: Drop workaround for old 32bit CPUs
Date: Wed, 8 Jul 2020 13:16:47 +0200	[thread overview]
Message-ID: <20200708111647.GC7191@Air-de-Roger> (raw)
In-Reply-To: <12874bc4-39e8-5ed4-3893-79154a206293@citrix.com>

On Wed, Jul 08, 2020 at 11:52:57AM +0100, Andrew Cooper wrote:
> On 08/07/2020 11:48, Roger Pau Monné wrote:
> > On Wed, Jul 08, 2020 at 11:14:43AM +0100, Andrew Cooper wrote:
> >>  	/*  Check upper bits of base and last are equal and lower bits are 0
> >>  	    for base and 1 for last  */
> >>  	last = base + size - 1;
> > FWIW, you could also initialize last at definition time.
> 
> I've got some very different cleanup in mind for that code, seeing as it
> can be simplified to a single test expression.

Oh, I certainly didn't look at it that much :).

Thanks, Roger.