From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Wei Shuai <cpuwolf@gmail.com>
Cc: "open list:INPUT (KEYBOARD, MOUSE, JOYSTICK,
TOUCHSCREEN)..." <linux-input@vger.kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jeffrey Hugo <jhugo@codeaurora.org>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
Borislav Petkov <bp@suse.de>, Mattias Jacobsson <2pi@mok.nu>,
Mark Gross <mgross@linux.intel.com>,
Russell King <rmk+kernel@armlinux.org.uk>,
Erwan Velu <e.velu@criteo.com>,
Thomas Gleixner <tglx@linutronix.de>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Input: break joystick limitation of maximum 80 buttons
Date: Mon, 13 Jul 2020 12:06:53 +0300 [thread overview]
Message-ID: <20200713090653.GB3703480@smile.fi.intel.com> (raw)
In-Reply-To: <CACa7zykn0q9XJAUvrqnNATr4DUv3Kc7XujF3vm6sfRB5pE6YNQ@mail.gmail.com>
On Sun, Jul 12, 2020 at 07:54:54AM +0800, Wei Shuai wrote:
> The joystick max buttons 80 limitation comes from
>
> #define BTN_JOYSTICK 0x120
> #define BTN_DEAD 0x12f
> #define BTN_TRIGGER_HAPPY 0x2c0
> #define KEY_MAX 0x2ff
>
> include/uapi/linux/input-event-codes.h
>
> according to function hidinput_configure_usage() in file drivers/hid/hid-input.c
>
> the joystick button mapping is not a continues space
> generally speaking, the mapping space is from
>
> 1. BTN_JOYSTICK~BTN_DEAD
> 2. BTN_TRIGGER_HAPPY~KEY_MAX
>
> Finally, I got the max limitation is 80.
> The patch is expanding KEY_MAX from 0x2ff to 4ff
> and the change has been verified on 104 button USB HID device on Ubuntu
If you send and resend this patch too often, nobody will take you seriously.
Also, you have to provide versioning and changelog in each submission.
Besides that, above doesn't answer to question "why?". Why are you doing this
at all? What the problem?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-07-13 9:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-10 6:51 [PATCH] break joystick limitation of maximum 80 buttons Wei Shuai
2020-07-11 23:54 ` [PATCH] Input: " Wei Shuai
2020-07-13 9:06 ` Andy Shevchenko [this message]
2020-07-13 10:29 ` Wei Shuai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200713090653.GB3703480@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=2pi@mok.nu \
--cc=bp@suse.de \
--cc=cpuwolf@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=e.velu@criteo.com \
--cc=gregkh@linuxfoundation.org \
--cc=jhugo@codeaurora.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mgross@linux.intel.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.