All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Seth Forshee <seth.forshee@canonical.com>
Cc: Alberto Milone <alberto.milone@canonical.com>,
	linux-fsdevel@vger.kernel.org, mingo@kernel.org
Subject: Re: [PATCH 1/1] radix-tree: do not export radix_tree_preloads as GPL
Date: Fri, 17 Jul 2020 16:31:51 +0200	[thread overview]
Message-ID: <20200717143151.d2umpurzatx3kfg2@linutronix.de> (raw)
In-Reply-To: <20200717142848.GK3644@ubuntu-x1>

On 2020-07-17 09:28:48 [-0500], Seth Forshee wrote:
> 
> Looks like the driver is not using idr_preload_end() though, it is
> calling radix_tree_preload_end() which uses radix_tree_preloads whether
> or not CONFIG_DEBUG_LOCK_ALLOC is enabled.

static inline void radix_tree_preload_end(void)
 {
         local_unlock(&radix_tree_preloads.lock);
 }

=> 
 #define local_unlock(lock)              __local_unlock(lock)

=>
 #define __local_unlock(lock)                                    \
         do {                                                    \
                 local_lock_release(this_cpu_ptr(lock));         \
                 preempt_enable();                               \
         } while (0)

=>
 static inline void local_lock_release(local_lock_t *l) { }

> Thanks,
> Seth

Sebastian

  reply	other threads:[~2020-07-17 14:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-17 10:18 [PATCH 1/1] radix-tree: do not export radix_tree_preloads as GPL Alberto Milone
2020-07-17 10:43 ` Sebastian Andrzej Siewior
     [not found]   ` <ba5d59f6-2e40-d13a-ecc8-d8430a1b6a14@canonical.com>
2020-07-17 12:35     ` Fwd: " Alberto Milone
2020-07-17 13:21     ` Sebastian Andrzej Siewior
2020-07-17 13:45       ` Alberto Milone
2020-07-17 14:28         ` Seth Forshee
2020-07-17 14:31           ` Sebastian Andrzej Siewior [this message]
2020-07-17 14:34           ` Seth Forshee
     [not found]             ` <20200717155519.GM3644@ubuntu-x1>
2020-07-20 14:49               ` Seth Forshee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200717143151.d2umpurzatx3kfg2@linutronix.de \
    --to=bigeasy@linutronix.de \
    --cc=alberto.milone@canonical.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=seth.forshee@canonical.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.