From: Gerd Hoffmann <kraxel@redhat.com>
To: Christophe de Dinechin <dinechin@redhat.com>
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
qemu-devel@nongnu.org,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: Re: [PATCH] spice: simplify chardev setup
Date: Wed, 22 Jul 2020 13:26:10 +0200 [thread overview]
Message-ID: <20200722112610.hkw3udjlfdm5vtii@sirius.home.kraxel.org> (raw)
In-Reply-To: <lytuxzhpnk.fsf@redhat.com>
On Wed, Jul 22, 2020 at 11:20:31AM +0200, Christophe de Dinechin wrote:
>
> On 2020-07-22 at 10:49 CEST, Gerd Hoffmann wrote...
> > Initialize spice before chardevs. That allows to register the spice
> > chardevs directly in the init function and removes the need to maintain
> > a linked list of chardevs just for registration.
> >
> > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
>
> Looks good to me, but I still need to test how this integrates with my work
> on putting SPICE in a module.
Hope it simplifies things. Removes qemu_spice_register_ports(), so one
item less you have to wire up in QemuSpiceOps.
With the qom module bits being merged meanwhile too it should be easier
now to turn chardev/spice.c into a module.
take care,
Gerd
prev parent reply other threads:[~2020-07-22 11:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-22 8:49 [PATCH] spice: simplify chardev setup Gerd Hoffmann
2020-07-22 9:20 ` Christophe de Dinechin
2020-07-22 10:19 ` Christophe de Dinechin
2020-07-22 11:18 ` Gerd Hoffmann
2020-07-23 8:26 ` Christophe de Dinechin
2020-07-22 11:26 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200722112610.hkw3udjlfdm5vtii@sirius.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=dinechin@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.