From: Sean Christopherson <sean.j.christopherson@intel.com>
To: Peter Xu <peterx@redhat.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
Andrew Jones <drjones@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v11 02/13] KVM: X86: Don't track dirty for KVM_SET_[TSS_ADDR|IDENTITY_MAP_ADDR]
Date: Wed, 22 Jul 2020 17:29:40 -0700 [thread overview]
Message-ID: <20200723002940.GO9114@linux.intel.com> (raw)
In-Reply-To: <20200708193408.242909-3-peterx@redhat.com>
On Wed, Jul 08, 2020 at 03:33:57PM -0400, Peter Xu wrote:
> Originally, we have three code paths that can dirty a page without
> vcpu context for X86:
>
> - init_rmode_identity_map
> - init_rmode_tss
> - kvmgt_rw_gpa
>
> init_rmode_identity_map and init_rmode_tss will be setup on
> destination VM no matter what (and the guest cannot even see them), so
> it does not make sense to track them at all.
>
> To do this, allow __x86_set_memory_region() to return the userspace
> address that just allocated to the caller. Then in both of the
> functions we directly write to the userspace address instead of
> calling kvm_write_*() APIs.
>
> Another trivial change is that we don't need to explicitly clear the
> identity page table root in init_rmode_identity_map() because no
> matter what we'll write to the whole page with 4M huge page entries.
>
> Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
Reviewed-by: Sean Christopherson <sean.j.christopherson@intel.com>
next prev parent reply other threads:[~2020-07-23 0:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-08 19:33 [PATCH v11 00/13] KVM: Dirty ring interface Peter Xu
2020-07-08 19:33 ` [PATCH v11 01/13] KVM: Cache as_id in kvm_memory_slot Peter Xu
2020-07-23 0:27 ` Sean Christopherson
2020-07-08 19:33 ` [PATCH v11 02/13] KVM: X86: Don't track dirty for KVM_SET_[TSS_ADDR|IDENTITY_MAP_ADDR] Peter Xu
2020-07-23 0:29 ` Sean Christopherson [this message]
2020-07-08 19:33 ` [PATCH v11 03/13] KVM: Pass in kvm pointer into mark_page_dirty_in_slot() Peter Xu
2020-07-08 19:33 ` [PATCH v11 04/13] KVM: X86: Implement ring-based dirty memory tracking Peter Xu
2020-07-08 19:34 ` [PATCH v11 05/13] KVM: Make dirty ring exclusive to dirty bitmap log Peter Xu
2020-07-08 19:34 ` [PATCH v11 06/13] KVM: Don't allocate dirty bitmap if dirty ring is enabled Peter Xu
2020-07-08 19:34 ` [PATCH v11 07/13] KVM: selftests: Always clear dirty bitmap after iteration Peter Xu
2020-07-08 19:34 ` [PATCH v11 08/13] KVM: selftests: Sync uapi/linux/kvm.h to tools/ Peter Xu
2020-07-08 19:34 ` [PATCH v11 09/13] KVM: selftests: Use a single binary for dirty/clear log test Peter Xu
2020-07-08 19:34 ` [PATCH v11 10/13] KVM: selftests: Introduce after_vcpu_run hook for dirty " Peter Xu
2020-07-08 19:34 ` [PATCH v11 11/13] KVM: selftests: Add dirty ring buffer test Peter Xu
2020-07-08 19:34 ` [PATCH v11 12/13] KVM: selftests: Let dirty_log_test async for dirty ring test Peter Xu
2020-07-08 19:34 ` [PATCH v11 13/13] KVM: selftests: Add "-c" parameter to dirty log test Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200723002940.GO9114@linux.intel.com \
--to=sean.j.christopherson@intel.com \
--cc=dgilbert@redhat.com \
--cc=drjones@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.