From: Ian Jackson <ian.jackson@eu.citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Subject: [OSSTEST PATCH 03/11] sg-report-host-history: Drop per-job debug etc.
Date: Fri, 24 Jul 2020 18:22:08 +0100 [thread overview]
Message-ID: <20200724172216.28204-4-ian.jackson@eu.citrix.com> (raw)
In-Reply-To: <20200724172216.28204-1-ian.jackson@eu.citrix.com>
This printing has a significant effect on the performance of this
program, at least after we optimise various other things.
Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
---
sg-report-host-history | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/sg-report-host-history b/sg-report-host-history
index 5dd875c1..8b409fc7 100755
--- a/sg-report-host-history
+++ b/sg-report-host-history
@@ -102,9 +102,9 @@ sub read_existing_logs ($) {
my $k = $1;
s{\%([0-9a-f]{2})}{ chr hex $1 }ge;
$ch->{$k} = $_;
- print DEBUG "GOTCACHE $hostname $k\n";
+# print DEBUG "GOTCACHE $hostname $k\n";
}
- print DEBUG "GOTCACHE $hostname \@ $jr->{flight} $jr->{job} $jr->{status},$jr->{name}\n";
+# print DEBUG "GOTCACHE $hostname \@ $jr->{flight} $jr->{job} $jr->{status},$jr->{name}\n";
$tcache->{$jr->{flight},$jr->{job},$jr->{status},$jr->{name}} = $jr;
}
close H;
@@ -272,7 +272,7 @@ END
my @rows;
my $cachehits = 0;
foreach my $jr (@$inrows) {
- print DEBUG "JOB $jr->{flight}.$jr->{job} ";
+ #print DEBUG "JOB $jr->{flight}.$jr->{job} ";
my $cacherow =
$tcache->{$jr->{flight},$jr->{job},$jr->{status},$jr->{name}};
@@ -283,11 +283,11 @@ END
my $endedrow = jobquery($endedq, $jr, 'e');
if (!$endedrow) {
- print DEBUG "no-finished\n";
+ #print DEBUG "no-finished\n";
next;
}
- print DEBUG join " ", map { $endedrow->{$_} } sort keys %$endedrow;
- print DEBUG ".\n";
+ #print DEBUG join " ", map { $endedrow->{$_} } sort keys %$endedrow;
+ #print DEBUG ".\n";
push @rows, { %$jr, %$endedrow };
}
@@ -329,7 +329,7 @@ END
next;
}
- print DEBUG "JR $jr->{flight}.$jr->{job}\n";
+ #print DEBUG "JR $jr->{flight}.$jr->{job}\n";
my $ir = jobquery($infoq, $jr, 'i');
my $ar = jobquery($allocdq, $jr, 'a');
my $ident = $jr->{name};
--
2.20.1
next prev parent reply other threads:[~2020-07-24 17:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-24 17:22 [OSSTEST PATCH 00/11] Improve performance of sg-report-host-history Ian Jackson
2020-07-24 17:22 ` [OSSTEST PATCH 01/11] schema: Add index for quick lookup by host Ian Jackson
2020-07-24 17:22 ` [OSSTEST PATCH 02/11] sg-report-host-history: Find flight limit by flight start date Ian Jackson
2020-07-24 17:22 ` Ian Jackson [this message]
2020-07-24 17:22 ` [OSSTEST PATCH 04/11] Executive: Export opendb_tests Ian Jackson
2020-07-24 17:22 ` [OSSTEST PATCH 05/11] sg-report-host-history: Add a debug print after sorting jobs Ian Jackson
2020-07-24 17:22 ` [OSSTEST PATCH 06/11] sg-report-host-history: Do the main query per host Ian Jackson
2020-07-24 17:22 ` [OSSTEST PATCH 07/11] sg-report-host-history: Rerganisation: Make mainquery per-host Ian Jackson
2020-07-24 17:22 ` [OSSTEST PATCH 08/11] sg-report-host-history: Rerganisation: Read old logs later Ian Jackson
2020-07-24 17:22 ` [OSSTEST PATCH 09/11] sg-report-host-history: Rerganisation: Change loops Ian Jackson
2020-07-24 17:22 ` [OSSTEST PATCH 10/11] sg-report-host-history: Drop a redundznt AND clause Ian Jackson
2020-07-24 17:22 ` [OSSTEST PATCH 11/11] sg-report-host-history: Fork Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200724172216.28204-4-ian.jackson@eu.citrix.com \
--to=ian.jackson@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.