From: Jason Gunthorpe <jgg@nvidia.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: Doug Ledford <dledford@redhat.com>,
Artemy Kovalyov <artemyko@mellanox.com>,
<linux-rdma@vger.kernel.org>
Subject: Re: [PATCH rdma-rc] RDMA/mlx5: Fix prefetch memory leak if get_prefetchable_mr fails
Date: Mon, 27 Jul 2020 11:57:26 -0300 [thread overview]
Message-ID: <20200727145726.GB48880@nvidia.com> (raw)
In-Reply-To: <20200727095712.495652-1-leon@kernel.org>
On Mon, Jul 27, 2020 at 12:57:12PM +0300, Leon Romanovsky wrote:
> From: Jason Gunthorpe <jgg@nvidia.com>
>
> destroy_prefetch_work() must always be called if the work is not going
> to be queued. The num_sge also should have been set to i, not i-1
> which avoids the condition where it shouldn't have been called in the
> first place.
>
> Cc: stable@vger.kernel.org
> Fixes: fb985e278a30 ("RDMA/mlx5: Use SRCU properly in ODP prefetch")
> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
> Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
> ---
> drivers/infiniband/hw/mlx5/odp.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
Applied to for-rc
Jason
prev parent reply other threads:[~2020-07-27 14:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-27 9:57 [PATCH rdma-rc] RDMA/mlx5: Fix prefetch memory leak if get_prefetchable_mr fails Leon Romanovsky
2020-07-27 14:57 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200727145726.GB48880@nvidia.com \
--to=jgg@nvidia.com \
--cc=artemyko@mellanox.com \
--cc=dledford@redhat.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.